Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sass to Hugo pipes #16028

Merged
merged 2 commits into from
Dec 3, 2024
Merged

move sass to Hugo pipes #16028

merged 2 commits into from
Dec 3, 2024

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Dec 1, 2024

build CSS with Hugo, rather than with our own custom makefile. This means that changes to the .scss files can be previewed in the regular Hugo workflow.

@craigbox craigbox requested a review from a team as a code owner December 1, 2024 09:56
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2024
@craigbox craigbox linked an issue Dec 1, 2024 that may be closed by this pull request
@craigbox craigbox closed this Dec 1, 2024
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2024
@craigbox craigbox reopened this Dec 1, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2024
@craigbox
Copy link
Contributor Author

craigbox commented Dec 2, 2024

Previews well on Netlify, which uses the extended build of Hugo.
Fails lint, which doesn't.

istio/tools#3074 will fix the lint error by changing which version of Hugo we bundle.

@dhawton
Copy link
Member

dhawton commented Dec 2, 2024

/test lint

1 similar comment
@craigbox
Copy link
Contributor Author

craigbox commented Dec 2, 2024

/test lint

@craigbox
Copy link
Contributor Author

craigbox commented Dec 2, 2024

/test lint
as istio/test-infra#5528 has now landed
and we watch the change propagate through the repos

@craigbox craigbox requested a review from dhawton December 2, 2024 22:34
@craigbox craigbox added the cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch label Dec 2, 2024
@istio-testing istio-testing merged commit 18bca5c into istio:master Dec 3, 2024
6 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fr: integrate scss into Hugo
3 participants