-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: Allow config parser to detect environment variables #397
Comments
I'd be wary of having Isso be configured from multiple places. For now, it already reads Having too many possible scenarios of mixed configs and inputs creates an untenable situation for testing. A bug in the parsing of another env variable slipped completely under the radar for that reason, see #720 You'd also have to deal with which config source would take precedence and what to do with duplicates. Parsing env variables, which is untrusted input that potentially any user can set, also creates a bit of a security nightmare. I'm doing to close this for now, unless you have a valid reason for this feature to be implemented. |
Not allowing env vars doesn't provide any additional security if the system is compromised, and it makes it harder for system administration because I can't check the config into source control systems so I have to manage it by hand every time I (re)install isso (via docker, etc). |
Having thought about this a bit, your arguments convince me. |
Related: #763 |
- Updated `IssoParser` to support environment variable substitution. - Enhanced documentation to include details on using environment variables in the configuration file. - Added unit tests to verify the functionality of environment variable substitution in `IssoParser`. Closes isso-comments#397
- Updated `IssoParser` to support environment variable substitution. - Enhanced documentation to include details on using environment variables in the configuration file. - Added unit tests to verify the functionality of environment variable substitution in `IssoParser`. Closes isso-comments#397
- Updated `IssoParser` to support environment variable substitution. - Enhanced documentation to include details on using environment variables in the configuration file. - Added unit tests to verify the functionality of environment variable substitution in `IssoParser`. Closes isso-comments#397
- Updated `IssoParser` to support environment variable substitution. - Enhanced documentation to include details on using environment variables in the configuration file. - Added unit tests to verify the functionality of environment variable substitution in `IssoParser`. Closes isso-comments#397
relevant code section: https://github.com/posativ/isso/blob/7f55c81e0875e1564eeab8ec6dd605c5699c9137/isso/config.py#L129-L130
See: https://stackoverflow.com/questions/26586801/configparser-and-string-interpolation-with-env-variable
The text was updated successfully, but these errors were encountered: