You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a minor thing, but since I just spent an embarrassingly long amount of time puzzling over it, I figured I’d mention it.
The documentation for fs.writeFile in the README mentions that "data should be a string of a Uint8Array."—which I interpreted as any data has to be converted into a Uint8Array and then encoded into a string. Looking through the source I noticed, however, that the function actually does the encoding for us if a string is passed.
Maybe this could be clarified? It might be just me, but the wording along with the amounts of time I have seen "or" misspelled as "of" really confused me here. 😅
Either way, thank you so much for this library (and the rest of Isomorphic Git!).
Happy holidays, if you celebrate.
The text was updated successfully, but these errors were encountered:
This is a minor thing, but since I just spent an embarrassingly long amount of time puzzling over it, I figured I’d mention it.
The documentation for
fs.writeFile
in the README mentions that "data
should be a string of a Uint8Array."—which I interpreted as any data has to be converted into a Uint8Array and then encoded into a string. Looking through the source I noticed, however, that the function actually does the encoding for us if a string is passed.Maybe this could be clarified? It might be just me, but the wording along with the amounts of time I have seen "or" misspelled as "of" really confused me here. 😅
Either way, thank you so much for this library (and the rest of Isomorphic Git!).
Happy holidays, if you celebrate.
The text was updated successfully, but these errors were encountered: