Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Backend Cleanup 2 #469

Open
9 tasks
rc-davis opened this issue Jul 7, 2022 · 1 comment
Open
9 tasks

Misc Backend Cleanup 2 #469

rc-davis opened this issue Jul 7, 2022 · 1 comment

Comments

@rc-davis
Copy link
Contributor

rc-davis commented Jul 7, 2022

The following miscellaneous cleanup items were identified when working on Tooling issue 453.

This continues where #461 leaves off.

  • re-export middleware from middleware/index.ts.
  • Move authenticatedSites into a new subdir authenticated/sites and merge authenticated/sites.js into the new authenticated/sites/index.js. (also setup subrouters in server.js?)
  • Distribute identity services into other sub-directories
  • Rename one either services/identity/SitesService or services/utilServices/SitesService
  • Rename MailClient to MailService (same for SmsClient?)
  • Stop mixing import and require in server.js
  • Create a FormsgService that contains most of FormsgRouter.formsgCreateSite()
  • Remove apiTokenName from Sites table.
  • Add unit and integration tests for newly introduced services and routes
@rc-davis rc-davis mentioned this issue Jul 8, 2022
3 tasks
@rc-davis rc-davis changed the title Misc Backend Cleanup Misc Backend Refactoring 2 Jul 8, 2022
@rc-davis rc-davis changed the title Misc Backend Refactoring 2 Misc Backend Cleanup 2 Jul 8, 2022
@seaerchin
Copy link
Contributor

we should also add unit + integration tests for the newly introduced services/routes in #456 and #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants