Expose dtCrowdAgentAnimation

[rob-myers]

Hey, I would like to cancel an offMeshConnection traversal.

I can detect if one has started via agent.state() === 2, but I cannot currently prevent an agent from following it.

Even if I remove the agent from the crowd and re-add it, the connection is followed.

Can we somehow expose dtCrowdAgentAnimation so I can set active to be false?

https://github.com/recastnavigation/recastnavigation/blob/455a019e7aef99354ac3020f04c1fe3541aa4d19/DetourCrowd/Source/DetourCrowd.cpp#L1415

[rob-myers]

I will try extending:

https://github.com/isaac-mason/recast-navigation-js/blob/07710dccfbcb8ffaf7202905887b82faddc25093/packages/recast-navigation-wasm/src/Crowd.cpp

---

Update: Exposing dtCrowdAgentAnimation requires editing the underlying repo e.g.

// packages/recast-navigation-wasm/recastnavigation/DetourCrowd/Source/DetourCrowd.cpp
dtCrowdAgentAnimation* dtCrowd::getAgentAnimation(const int idx)
{
	if (idx < 0 || idx >= m_maxAgents)
		return 0;
	return &m_agentAnims[idx];
}

We can follow DEVELOPMENT.md, change build.sh to pull from a forked recastnavigation, then run yarn build inside packages/recast-navigation-wasm. Finally we can hook-up these changes:

// locally by changing tsconfig.json in my repo
"paths": {
  "@recast-navigation/core": ["../recast-navigation-js/packages/recast-navigation-core"],
  "@recast-navigation/generators": ["../recast-navigation-js/packages/recast-navigation-generators"],
  "@recast-navigation/three": ["../recast-navigation-js/packages/recast-navigation-three"],
  "@recast-navigation/wasm": ["../recast-navigation-js/packages/recast-navigation-wasm"]
},

// in production by re-publishing scoped modules e.g.
"@recast-navigation/core": "npm:@rob-myers/[email protected]",
"@recast-navigation/generators": "npm:@rob-myers/[email protected]",
"@recast-navigation/three": "npm:@rob-myers/[email protected]",
"@recast-navigation/wasm": "npm:@rob-myers/[email protected]",

I'd be interested if there's another way @isaac-mason ? I'm guessing you don't want to extend the underlying repo, even if offMeshConnections are a bit of a mess.

Btw, it seems pretty easy to "smooth" the offMeshConnection traversal.

rob-myers/recastnavigation@7e5b66e

[isaac-mason]

Hey @rob-myers!

If you have the appetite to do it, it would be most ideal to upstream improvements to the recastnavigation repo. Although afaik Mikko is not actively involved anymore, there are other contributors maintaining the repo that could help merge improvements to off mesh connections.

Otherwise linking recast-navigation-js to your own fork for your own usage is certainly a way forward. I'd probably prefer not to modify the fork that the recast-navigation-js repo uses though to keep maintenance low though.

[rob-myers]

Fair enough. The upstream repo expects developers to extend/modify the C++ code themselves, if necessary, so it could be bit tricky requesting my changes. I'll have a go once I've fixed all the problems I'm working on.

Btw what's the right way to simultaneously publish a patch version of core/generators/three/wasm both in their package.json version and dependencies? I'm currently doing it manually.

[isaac-mason]

Btw what's the right way to simultaneously publish a patch version of core/generators/three/wasm both in their package.json version and dependencies? I'm currently doing it manually.

I use changesets in the repo, so you can use yarn run change to create files describing changes, then yarn run version to create version bumps from generated changeset files

[isaac-mason]

Fair enough. The upstream repo expects developers to extend/modify the C++ code themselves, if necessary, so it could be bit tricky requesting my changes. I'll have a go once I've fixed all the problems I'm working on.

That's a fair point, and a common & unfortunate rough edge with trying to make a general wasm library - it's hard to make it highly extensible - it's often easier for serious users to start writing their own opinionated wrapper c++ code etc.

An addition along the lines of Unity's NavMeshAgent.autoTraverseOffMeshLink and NavMeshAgent.CompleteOffMeshLink APIs could be a valuable and general enough additions to recastnavigation. These APIs could let users create any off mesh traversal logic without having to change source code.

https://docs.unity3d.com/6000.0/Documentation/ScriptReference/AI.NavMeshAgent-autoTraverseOffMeshLink.html
https://docs.unity3d.com/6000.0/Documentation/ScriptReference/AI.NavMeshAgent.CompleteOffMeshLink.html
https://docs.unity3d.com/6000.0/Documentation/ScriptReference/AI.NavMeshAgent-isOnOffMeshLink.html

[rob-myers]

yarn run change

When I bump the patch version of core/generators/three/wasm, this bumps the "version" field in each package.json, but it does not simultaneously bump the dependencies. I would like e.g. @rob-myers/[email protected] to have dependency @recast-navigation/[email protected].

I'm doing:

yarn change
yarn changeset version

Then manually changing the dependency versions.
I wonder if there's a better way?