Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some vibrations cause inputs to lock up until it stops #501

Open
isXander opened this issue Jan 13, 2025 · 6 comments
Open

Some vibrations cause inputs to lock up until it stops #501

isXander opened this issue Jan 13, 2025 · 6 comments
Labels
bug Something isn't working high-priority in-progress SDL Related to SDL

Comments

@isXander
Copy link
Owner

isXander commented Jan 13, 2025

This is the tracking issue for the many reports of this.

Description

When Controlify triggers certain vibration effects in game, like using a shield, falling into water, and getting damaged, the controller inputs stop responding for the duration of the vibration effect. It works as normal afterwards.

Environments

This only happens when using SDL.

  • DualSense
    • macOS (assumed HIDAPI)
    • Windows (assumed HIDAPI)
  • DualShock 4
    • Windows (assumed HIDAPI)
    • macOS (assumed HIDAPI)
  • DualShock 3
    • Linux (assumed HIDAPI)
  • Switch Pro Controller
    • Windows (assumed HIDAPI)
  • 8Bitdo Pro 2
    • X-input mode: No issue
    • Switch mode: Issue (assumed HIDAPI)

Issue references

Controlify

#500 #383 #492 #331 #270

SDL

libsdl-org/SDL#9441

@isXander isXander added bug Something isn't working high-priority in-progress SDL Related to SDL labels Jan 13, 2025
@isXander isXander pinned this issue Jan 13, 2025
@isXander
Copy link
Owner Author

@turtlekoopa @allavyazmin @Zytronium @XXCheekyBastardXX @sodul @fianalins @Gabibag @Mirror995 @chytreg @deltaryz

I would like some testers in the coming days to test possible fixes for this, since I cannot experience it myself. If you are willing, please join my discord server and ping me (tell me why you're pinging!). I will add you to a channel where I will send some builds in the coming days.

@isXander
Copy link
Owner Author

https://gofile.io/d/9T4AYf

This build is for Fabric 1.21.4. All that are affected, please try this build and see if it still happens.

@fianalins
Copy link

fianalins commented Jan 14, 2025

I just very quickly tested this and the version uploaded to Modrinth.
In this fixed version, the controls don't lock up, but also the vibrations feel a lot more toned down? As if the strength was turned down, even though it wasn't.

I tried the Modrinth (unpacked) version, and it locks input. I also noticed it happens when pressing the "Test Vibrations", where it freezes for the first couple seconds and doesn't allow me to control the UI.

Also, unrelated to the vibration issue, this fixed version allows me to press on the Settings button with my mouse in the Controller Settings menu, where the Modrinth version doesn't.

@allavyazmin
Copy link

no sorry im fine with it

@iatsiuk
Copy link

iatsiuk commented Jan 19, 2025

  • Operating System: macOS 15.2
  • Hardware: Apple M2 Pro
  • Controller: Sony DualSense (PS5)

The application crashes immediately upon button press after world load.

crash-2025-01-19_17.49.59-client.txt

@isXander
Copy link
Owner Author

The cause of the issue has been identified. We will now have to wait patiently for SDL to release a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority in-progress SDL Related to SDL
Projects
None yet
Development

No branches or pull requests

4 participants