Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support directives #pragma and #include_next in PreProcessor::skipIf #15

Open
dirx opened this issue May 1, 2020 · 1 comment
Open

Comments

@dirx
Copy link
Contributor

dirx commented May 1, 2020

Even though there is no support for

  • include_next
  • pragma

currently, it would be nice to add at least support for them in skipIf to "work around" them.

Maybe also skip:

  • ident
  • line
  • sccs
  • assert
  • unassert
  • import
@ircmaxell
Copy link
Owner

Totally okay adding ignores for ones that are logically no-ops. Example: ident, we aren't generating binaries from these headers, so if we encounter it we can safely ignore it.

However something like include_next definitely alters the behavior and would need support. I think I'd rather hard-error if it's not implemented rather than generate wrong or incomplete code by not handling it...

Looking at that list, ident, sccs, and line fit that bill.

Assert likely doesn't though, since it can prevent errors and things like that.

Import should likely be supported out of the box (and shouldn't be that hard either)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants