Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Nested monetization link tag not detected in page #881

Closed
DarianM opened this issue Jan 30, 2025 · 0 comments · Fixed by #882
Closed

[BUG] Nested monetization link tag not detected in page #881

DarianM opened this issue Jan 30, 2025 · 0 comments · Fixed by #882
Assignees
@sidvishnoi
Labels
area: content Improvements or additions to extension content script bug Something isn't working

Comments

@DarianM
Copy link
Member

DarianM commented Jan 30, 2025

Steps to reproduce

  1. Go to this monetized page ;
  2. Have a wallet connected
  3. Popup gives message This website is not monetized

Expected result

This page should be monetized after connecting the wallet since monetization link is present in the page's HTML.

Actual result

The MutationObserver from monetizationLinkManager that looks for the monetization link inside the page cannot pick this particular monetization link element.

Screenshots or videos

No response

Additional context

No response

Operating system

macOS

Operating system version

No response

Browsers

Chrome

Browser version

No response

Extension version

0.4.0.0
@DarianM DarianM added area: content Improvements or additions to extension content script bug Something isn't working labels Jan 30, 2025
@DarianM DarianM moved this from Backlog to Todo in Web Monetization Extension Jan 30, 2025
@sidvishnoi sidvishnoi moved this from Todo to In Progress in Web Monetization Extension Jan 30, 2025
@sidvishnoi sidvishnoi mentioned this issue Jan 30, 2025
Merged
@sidvishnoi sidvishnoi moved this from In Progress to In Review in Web Monetization Extension Jan 30, 2025
@sidvishnoi sidvishnoi self-assigned this Jan 31, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web Monetization Extension Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidvishnoi sidvishnoi

Labels
area: content Improvements or additions to extension content script bug Something isn't working
Projects
Web Monetization Extension
Status: Done
Milestone
No milestone
2 participants
@sidvishnoi @DarianM