Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seemingly unused or inconsistent data in meta.json #71

Open
Umaaz opened this issue Nov 22, 2023 · 0 comments
Open

Seemingly unused or inconsistent data in meta.json #71

Umaaz opened this issue Nov 22, 2023 · 0 comments

Comments

@Umaaz
Copy link
Member

Umaaz commented Nov 22, 2023

Describe the bug
When reviewing the meta.json for the blocks there are some data points that seem to be unused or inconsistent.

  • totalObjects vs totalRecords - objects are the number of snapshots in the block, records always seems to be 1. They are then referred to inconsistently in the code in compactor.go#60 for example.
  • indexPageSize - seems to be passed around during requests but never set or read
  • encoding and dataEncoding - should be reviewed to ensure these are correct

Expected behavior
Naming and usage should be consistent and clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant