Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Search limitations #2

Open
Umaaz opened this issue Apr 27, 2023 · 1 comment
Open

search: Search limitations #2

Umaaz opened this issue Apr 27, 2023 · 1 comment

Comments

@Umaaz
Copy link
Member

Umaaz commented Apr 27, 2023

In deep there is a limit on the way native search works. It will only search attribute/resource tags that are strings. This is the same as tempo. We can (I believe) fix this, but I assume this was done in tempo for a reason (maybe performance).

The open question is, do we need to support the complex types that tempo supports. Or do we just want these tags to be strings? at the moment a tab can be int, boolean, string, double, array, bytes, map. This makes it quite complex to render and search.

I cannot see a reason why these tags would be anything but strings.

@Umaaz
Copy link
Member Author

Umaaz commented Jun 12, 2023

We will convert all attributes to strings, as there is no need to have more complex types.

Another option would be to store a string of all the values in the queried value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant