From ed9a2857c29e889a332f86bf0873c48680d5b74a Mon Sep 17 00:00:00 2001 From: sys_igc Date: Sun, 2 Feb 2025 11:49:53 +0100 Subject: [PATCH] [Autobackout][FunctionalRegression]Revert of change: 185115eb0e6be14c6208dc46c21d75fdaaaa854f: Change polarity of RayQueryDynamicRayManagment opt flag/ail Originally opt enabled by default but due to several func issues (game crashes) and minimal perf benefit plan is to disabled this opt by default (and enable via AIL if needed) --- IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp | 2 +- IGC/common/MDFrameWork.h | 2 +- IGC/common/igc_flags.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp b/IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp index 796e62cd908a..2a5d30a85a52 100644 --- a/IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp +++ b/IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp @@ -145,7 +145,7 @@ void RayTracingInlineLowering(CodeGenContext* pContext) if (IGC_IS_FLAG_ENABLED(OverrideTMax)) mpm.add(createOverrideTMaxPass(IGC_GET_FLAG_VALUE(OverrideTMax))); - if (pContext->platform.isDynamicRayQueryDynamicRayManagementMechanismEnabled() && pContext->getModuleMetaData()->compOpt.EnableDynamicRQManagement) + if (pContext->platform.isDynamicRayQueryDynamicRayManagementMechanismEnabled() && !pContext->getModuleMetaData()->compOpt.DisableDynamicRQManagement) { mpm.add(CreateDynamicRayManagementPass()); } diff --git a/IGC/common/MDFrameWork.h b/IGC/common/MDFrameWork.h index de5a4712c246..58aabb1c9333 100644 --- a/IGC/common/MDFrameWork.h +++ b/IGC/common/MDFrameWork.h @@ -474,7 +474,7 @@ enum class ShaderTypeMD bool ForceLinearWalkOnLinearUAV = false; bool DisableLscSamplerRouting = false; bool UseBarrierControlFlowOptimization = false; - bool EnableDynamicRQManagement = false; + bool DisableDynamicRQManagement = false; unsigned Quad8InputThreshold = 0; bool UseResourceLoopUnrollNested = false; }; diff --git a/IGC/common/igc_flags.h b/IGC/common/igc_flags.h index 56357afa4b9e..fb84677678d2 100644 --- a/IGC/common/igc_flags.h +++ b/IGC/common/igc_flags.h @@ -1006,7 +1006,7 @@ DECLARE_IGC_GROUP("Raytracing Options") DECLARE_IGC_REGKEY(bool, EnableRTPrintf, false, "Enable printf for ray tracing.", true) DECLARE_IGC_REGKEY(DWORD, PrintfBufferSize, 0, "Set printf buffer size. Unit: KB.", true) DECLARE_IGC_REGKEY(bool, DisableRayQueryReturnOptimization, false, "RayQuery Return Optimization", true) - DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanism, true, "Dynamic ray management mechanism for Synchronous Ray Tracing", true) + DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanism, false, "Dynamic ray management mechanism for Synchronous Ray Tracing", true) DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanismForExternalFunctionsCalls, false, "Disable dynamic ray management mechanism for shaders with external functions calls", true) DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanismForBarriers, false, "Disable dynamic ray management mechanism for shaders with barriers", true) DECLARE_IGC_REGKEY(bool, EnableOuterLoopHoistingForRayQueryDynamicRayManagementMechanism, false, "Disable dynamic ray management mechanism for shaders with barriers", true)