Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Icons are displayed as large broken image placeholders in comments #337

Open
Remco-Schoeman opened this issue Oct 9, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Remco-Schoeman
Copy link

Describe the bug

We have a sonarcloud integration that posts comments with 'inline' status icons on pull requests.
To get live notifications in Teams, I've subscribed to new comments in the repo.
image

To Reproduce
Steps to reproduce the behavior:

  1. in the teams integration subscribe to comments on a repo with sonarcloud integration enabled.

Expected behavior
A comment in Teams that looks like the original comment:

image

or alternatively:

A comment stripped of the images, so it becomes a reasonable length

Actual Behavior
A comment in teams with 11 full-width broken image placeholders.
this makes the comment annoyingly long to scroll past.

image

Desktop (please complete the following information):

  • OS: Windows 11
  • Teams new desktop client.

Additional context

From the Teams about box:
Teams-version: 23257.2618.2432.4374.
Client version: 49/23091420225.

Raw source of the sonarcloud comment (when edited in the Github UI)

Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=REDACTED&pullRequest=REDACTED)

[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=BUG)  
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=VULNERABILITY)  
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=REDACTED&pullRequest=REDACTED&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=REDACTED&pullRequest=REDACTED&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=REDACTED&pullRequest=REDACTED&resolved=false&types=SECURITY_HOTSPOT)  
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=REDACTED&pullRequest=REDACTED&resolved=false&types=CODE_SMELL)

[![90.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png '90.4%')](https://sonarcloud.io/component_measures?id=REDACTED&pullRequest=REDACTED&metric=new_coverage&view=list) [90.4% Coverage](https://sonarcloud.io/component_measures?id=REDACTED&pullRequest=REDACTED&metric=new_coverage&view=list)  
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=REDACTED&pullRequest=REDACTED&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=REDACTED&pullRequest=REDACTED&metric=new_duplicated_lines_density&view=list)
@Remco-Schoeman Remco-Schoeman added the bug Something isn't working label Oct 9, 2023
@sae-artem
Copy link

+1, for me it makes the github-teams integration unusable, and I don't know if it's possible to unsubscribe to comments posted by SonarCloud bot only.

@bogdan-calapod
Copy link

This also occurs in the mobile Teams client (Android)

@adityahas
Copy link

adityahas commented Mar 20, 2024

I think this is due to the inability to load any images in PR, issues, comments, etc., in the private repository. The images needs valid JWT tokens in order to be loaded successfully.
The question is, if we've authorized the app to access our repos, why is it unable to obtain the valid JWT token to load the images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@adityahas @bogdan-calapod @Remco-Schoeman @sae-artem and others