Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pystac 1.0 compatability #93

Closed
TomAugspurger opened this issue Jun 14, 2021 · 2 comments
Closed

pystac 1.0 compatability #93

TomAugspurger opened this issue Jun 14, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@TomAugspurger
Copy link
Collaborator

PySTAC is preparing for 1.0, which includes some breaking changes. Running locally, I see some failures.

========================================================================================================= ERRORS =========================================================================================================
____________________________________________________________________________________ ERROR at setup of test_cat_from_item_collection _____________________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
________________________________________________________________________________________ ERROR at setup of test_cat_to_geopandas _________________________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
_____________________________________________________________________________ ERROR at setup of test_cat_to_geopandas_crs[IGNF:ETRS89UTM28] ______________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
________________________________________________________________________________ ERROR at setup of test_cat_to_geopandas_crs[epsg:26909] _________________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
____________________________________________________________________________________ ERROR at setup of test_cat_to_missing_geopandas _____________________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
_____________________________________________________________________________________ ERROR at setup of test_load_satsearch_results ______________________________________________________________________________________
E   pystac.errors.STACTypeError: JSON does not represent a STAC object.
======================================================================================================== FAILURES ========================================================================================================
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/catalog.py:302: ValueError: STAC Item must implement "eo" extension to use this method
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/catalog.py:302: ValueError: STAC Item must implement "eo" extension to use this method
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/catalog.py:302: ValueError: STAC Item must implement "eo" extension to use this method
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/tests/test_catalog.py:167: AssertionError: Regex pattern 'ANG not found in list of eo:bands in collection' does not match 'STAC Item must implement "eo" extension to use this method'.
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/tests/test_catalog.py:174: AssertionError: Regex pattern "'B8', 'B9', 'blue', 'cirrus'" does not match 'STAC Item must implement "eo" extension to use this method'.
/home/taugspurger/src/stac-extensions/intake-stac/intake_stac/catalog.py:302: ValueError: STAC Item must implement "eo" extension to use this method
================================================================================================ short test summary info =================================================================================================
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking - ValueError: STAC Item must implement "eo" extension to use this method
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking_using_common_name - ValueError: STAC Item must implement "eo" extension to use this method
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking_path_as_pattern - ValueError: STAC Item must implement "eo" extension to use this method
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking_dims_of_different_type_raises_error - AssertionError: Regex pattern 'ANG not found in list of eo:bands in collection' does not match 'STAC Item must i...
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking_dims_with_nonexistent_band_raises_error - AssertionError: Regex pattern "'B8', 'B9', 'blue', 'cirrus'" does not match 'STAC Item must implement "eo" e...
FAILED intake_stac/tests/test_catalog.py::test_cat_item_stacking_dims_of_different_size_regrids - ValueError: STAC Item must implement "eo" extension to use this method
ERROR intake_stac/tests/test_catalog.py::test_cat_from_item_collection - pystac.errors.STACTypeError: JSON does not represent a STAC object.
ERROR intake_stac/tests/test_catalog.py::test_cat_to_geopandas - pystac.errors.STACTypeError: JSON does not represent a STAC object.
ERROR intake_stac/tests/test_catalog.py::test_cat_to_geopandas_crs[IGNF:ETRS89UTM28] - pystac.errors.STACTypeError: JSON does not represent a STAC object.
ERROR intake_stac/tests/test_catalog.py::test_cat_to_geopandas_crs[epsg:26909] - pystac.errors.STACTypeError: JSON does not represent a STAC object.
ERROR intake_stac/tests/test_catalog.py::test_cat_to_missing_geopandas - pystac.errors.STACTypeError: JSON does not represent a STAC object.
ERROR intake_stac/tests/test_catalog.py::test_load_satsearch_results - pystac.errors.STACTypeError: JSON does not represent a STAC object.
========================================================================================= 6 failed, 13 passed, 6 errors in 9.74s =========================================================================================

I'll look into these over the next couple days.

@scottyhq
Copy link
Collaborator

scottyhq commented Jun 14, 2021

yep, i think this project should only work with STAC>=1.0 going forward, and pin pystac>=1.0 once released

@scottyhq scottyhq added this to the 0.4 release milestone Jun 21, 2021
@scottyhq scottyhq added the enhancement New feature or request label Jun 21, 2021
@TomAugspurger
Copy link
Collaborator Author

Closes by #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants