Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trials extractors to handle clean first trial #772

Open
7 tasks
k1o0 opened this issue Feb 24, 2025 · 0 comments
Open
7 tasks

Update trials extractors to handle clean first trial #772

k1o0 opened this issue Feb 24, 2025 · 0 comments
Assignees

Comments

@k1o0
Copy link
Contributor

k1o0 commented Feb 24, 2025

The next release of iblrig (which version number?) will no longer have the camera trigger in the main state machine, meaning the first trial will have a normal length Bpod TTL. The extractors should be updated accordingly.

  • Acquire test session with new state machine
  • Check for the specific state name: Trial 0 used to include a state named delay_initiation - this state no longer exists (see here). Should be safer than merely checking for the version (given custom tasks).
  • Modify extractors to check the version before attempting to reassign first trial pulses. See point above.
  • Timeline extractor and camlog extractor
  • Add integration test for extraction of trials with new state machine
  • Check that camera extraction is OK (should be - missing pulses at start are extrapolated)
  • Release ibllib changes before releasing iblrig

Relevant lines:
https://github.com/int-brain-lab/ibllib/blob/fa6d722c6970ad5a29ebefb44313e1f8d5a746c2/ibllib/io/extractors/ephys_fpga.py#L1184-L1195
https://github.com/int-brain-lab/ibllib/blob/fa6d722c6970ad5a29ebefb44313e1f8d5a746c2/ibllib/io/extractors/ephys_fpga.py#L949-L983

@k1o0 k1o0 changed the title extractors Update trials extractors to handle clean first trial Feb 24, 2025
@k1o0 k1o0 assigned k1o0 and bimac and unassigned k1o0 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants