forked from awong-dev/nokogiri-xmlsec-me-harder
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with Nokogiri 1.13.7 #12
Comments
radar
added a commit
to radar/nokogiri-xmlsec-instructure
that referenced
this issue
Jul 13, 2022
Nokogiri now uses this internally here: sparklemotion/nokogiri@720d6f4 Fixes instructure#12
radar
added a commit
to radar/nokogiri-xmlsec-instructure
that referenced
this issue
Jul 13, 2022
Nokogiri now uses this internally here: sparklemotion/nokogiri@720d6f4 Fixes instructure#12
👋 nokogiri maintainer here. I wasn't aware of how much this gem (and potentially others) are relying on nokogiri internals. I've added this gem to our downstream test suite in sparklemotion/nokogiri#2595 so I'm aware of breakage that's being introduced. I'd also like to offer up a PR to fix this ... give me a bit. |
Just noting that it's still broken with Nokogiri 1.18.1. Errors like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just posting this here so you're aware.
I'll see if I can get a fix through.
Possibly related to #9?
The text was updated successfully, but these errors were encountered: