-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR checks via GitHub actions #18
Comments
I'd be happy to take a first stab at it :-) |
Checks on PR would be useful. Would reduce the reliance on reviewers and the error handling on the processing backend to weed out incorrectly formatted yamls. |
Github actions will rerun when a new commit is pushed in the PR. To enable retest command on prow, we need to deploy the full prow cluster. The github action version of prow only support the following commands: |
sounds like there is some CLI-side work in this space: instructlab/instructlab#133 and instructlab/instructlab#205. |
I made the DCO check mandatory and added a simple YAML linter for An example of linter completing successfully in a few seconds: An example of linter catching formatting errors: Which also shows the offensive lines in the Files changed view for reviewers: My intention is to re-use what @lehors has code in instructlab/instructlab#133 and instructlab/instructlab#205 in a second iteration. |
The current CI checks do a basic `yamllint` but don't actually verify the `qna.yaml` files contain the required contents This PR updates the existing CI lint workflow: - Only run the linter when `qna.yaml` file(s) were changed - Add a step to identify only the `qna.yaml` file(s) changed in the PR - Use `yq` to check specific fields inside the `qna.yaml` file(s) - Generate a match-able log messages for missing/empty fields - Use a problem-matcher to parse the generate error messages to annotate the Changed files in the PR - Generate an error for knowledge contributions Resolves #18 --------- Signed-off-by: Christian Kadner <[email protected]>
GitHub actions along with concise Bash scripts could/should be employed to make sure the submitted "qna.yml" and "knowledge.md" files are formatted correctly (style and content structure)
The text was updated successfully, but these errors were encountered: