diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 1b325ec14..52c5ae25e 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -2,7 +2,7 @@ name: pypi on: release: - types: [created] + types: [published] jobs: deploy: diff --git a/mava/systems/tf/mappo/networks.py b/mava/systems/tf/mappo/networks.py index be6e60e8a..3aff327af 100644 --- a/mava/systems/tf/mappo/networks.py +++ b/mava/systems/tf/mappo/networks.py @@ -84,8 +84,6 @@ def make_default_networks( # Create the shared observation network; here simply a state-less operation. if observation_network is None: observation_network = tf2_utils.to_sonnet_module(tf.identity) - else: - observation_network = observation_network # Note: The discrete case must be placed first as it inherits from BoundedArray. if isinstance(specs[key].actions, dm_env.specs.DiscreteArray): # discrete diff --git a/mava/utils/environments/open_spiel_utils.py b/mava/utils/environments/open_spiel_utils.py index c2a71659a..d037861cc 100644 --- a/mava/utils/environments/open_spiel_utils.py +++ b/mava/utils/environments/open_spiel_utils.py @@ -19,7 +19,6 @@ _has_open_spiel = True except ModuleNotFoundError: _has_open_spiel = False - pass def load_open_spiel_env(game_name: str) -> "rl_environment.Environment": diff --git a/mava/utils/environments/pettingzoo_utils.py b/mava/utils/environments/pettingzoo_utils.py index 03dc8bbd2..29b23ea5c 100644 --- a/mava/utils/environments/pettingzoo_utils.py +++ b/mava/utils/environments/pettingzoo_utils.py @@ -27,7 +27,6 @@ _has_supersuit = True except ModuleNotFoundError: _has_supersuit = False - pass try: from smac.env.pettingzoo import StarCraft2PZEnv @@ -35,7 +34,6 @@ _has_smac = True except ModuleNotFoundError: _has_smac = False - pass try: import pettingzoo # noqa: F401 @@ -43,7 +41,6 @@ _has_petting_zoo = True except ModuleNotFoundError: _has_petting_zoo = False - pass from mava.wrappers import ( ParallelEnvWrapper, diff --git a/mava/utils/wrapper_utils.py b/mava/utils/wrapper_utils.py index 2fbb1bf7c..c55706c96 100644 --- a/mava/utils/wrapper_utils.py +++ b/mava/utils/wrapper_utils.py @@ -12,7 +12,6 @@ _has_petting_zoo = True except ModuleNotFoundError: _has_petting_zoo = False - pass # Need to install typing_extensions since we support pre python 3.8 from typing_extensions import TypedDict diff --git a/mava/wrappers/env_preprocess_wrappers.py b/mava/wrappers/env_preprocess_wrappers.py index 5c5691a1e..75396ff6d 100644 --- a/mava/wrappers/env_preprocess_wrappers.py +++ b/mava/wrappers/env_preprocess_wrappers.py @@ -29,7 +29,6 @@ _has_supersuit = True except ModuleNotFoundError: _has_supersuit = False - pass try: @@ -38,7 +37,6 @@ _has_petting_zoo = True except ModuleNotFoundError: _has_petting_zoo = False - pass if _has_petting_zoo: from pettingzoo.utils import BaseParallelWraper diff --git a/mava/wrappers/environment_loop_wrappers.py b/mava/wrappers/environment_loop_wrappers.py index 27b1e52d1..3769c0797 100644 --- a/mava/wrappers/environment_loop_wrappers.py +++ b/mava/wrappers/environment_loop_wrappers.py @@ -349,7 +349,6 @@ def _retrieve_render(self) -> Optional[np.ndarray]: ) except Exception as ex: print(f"Render frames exception: {ex}") - pass return render def _append_frame(self) -> None: @@ -382,7 +381,6 @@ def _write_frames(self) -> None: self._save_gif(path) except Exception as ex: print(f"Write frames exception: {ex}") - pass self._frames = [] # Clear matplotlib figures in memory plt.close("all")