Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roxy.shinylive #1472

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Add roxy.shinylive #1472

merged 8 commits into from
Feb 4, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 31, 2025 •
edited
Loading

Closes #1404

Note that the shinylive R apps will be broken till the teal is released on CRAN because we are unable to use the dev version of the packages from pharmaverse.r-universe because the webr binaries build there are only compatible with the webr REPL and not the shinylive yet.

@vedhav vedhav added documentation Improvements or additions to documentation enhancement New feature or request core labels Jan 31, 2025
@vedhav vedhav force-pushed the 1404-add-roxy.shinylive@main branch from 55c6050 to 6f6cec9 Compare February 3, 2025 14:50
@vedhav vedhav marked this pull request as ready for review February 3, 2025 14:51
vedhav added 2 commits February 3, 2025 20:23
@vedhav
Merge branch 'main' into 1404-add-roxy.shinylive@main
5980fbb 
# Conflicts:
#	vignettes/data-transform-as-shiny-module.Rmd
@vedhav
chore: ignore Shinylive
c967827
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Unit Tests Summary

  1 files   28 suites   10m 33s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit c814cc4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $133.02$ $-5.10$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💚 $43.41$ $-1.71$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $37.75$ $-1.08$ $0$ $0$ $0$ $0$
shinytest2-reporter 💚 $68.39$ $-1.80$ $0$ $0$ $0$ $0$
shinytest2-teal_data_module 💚 $48.44$ $-1.14$ $0$ $0$ $0$ $0$

Results for commit e6eb210

♻️ This comment has been updated with latest results.

gogonzo
gogonzo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All shiny examples in the docs do have @examplesShinylive section

@vedhav vedhav enabled auto-merge (squash) February 4, 2025 08:04
@vedhav vedhav merged commit d2217b3 into main Feb 4, 2025
29 checks passed
@vedhav vedhav deleted the 1404-add-roxy.shinylive@main branch February 4, 2025 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@gogonzo gogonzo self-assigned this Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gogonzo gogonzo gogonzo approved these changes

Assignees

@gogonzo gogonzo

Labels
core documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[idea] use Shinylive in pkg docs
2 participants
@vedhav @gogonzo