-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lookup-refs, vbump dependencies + add Remotes #403
Conversation
Unit Tests Summary 1 files 15 suites 8s ⏱️ Results for commit 95aca7d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could install the package without further problems from this branch using only remotes (to test the new Remotes field). The logs show it picked packages from github.
But somehow it installed packages from Bioconductor 3.18. While current version is 3.20 (just noting this but I think it is unrelated to the PR but might confuse or cause problems for the users):
remotes::install_github("insightsengineering/teal.modules.hermes@remove_lookups")
...
https://bioconductor.org/packages/3.18/bioc/src/...'
...
Downloading GitHub repo insightsengineering/teal@HEAD
....
Done
@llrs-roche what is your version of R locally? R local version is tied to Bioconductor version. I think if you R is old, then you'll pick up from the old Bioconductor during the installation? |
Yes, but my R version is 4.4.2 which matches where Bioconductor 3.20 is meant to be used. It could be a problem on my local setup too |
Signed-off-by: Marcin <[email protected]>
cc @pawelru @llrs-roche I vbumped teal.widgets to it's version released on CRAN |
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install
,renv::install
andremotes::install
.With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.