Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move data regeneration from vignette to data-raw #318

Closed
shajoezhu opened this issue Sep 28, 2024 · 4 comments · Fixed by #323
Closed

move data regeneration from vignette to data-raw #318

shajoezhu opened this issue Sep 28, 2024 · 4 comments · Fixed by #323
Labels

Comments

@shajoezhu
Copy link
Contributor

No description provided.

@shajoezhu shajoezhu added the sme label Sep 28, 2024
@Melkiades
Copy link
Contributor

You mean the script? I think it is better to have it visible

@shajoezhu
Copy link
Contributor Author

something like we did in tern and chevron, use data-raw

the vignette folder is not the best place for this document I think. A bit confusing, I think the user of this doc/script should be developer

@Melkiades
Copy link
Contributor

This package's purpose is to create cached, synthetic data sets. The vignette shows how to do that and should remain visible. Certainly, I would improve its description and add a pre-processing/data visualization vignette

@shajoezhu
Copy link
Contributor Author

i think we should have seperate vignettes for a general user, and developer, i think we can take the code here to data-raw, and shape this vignette to a developer piece

shajoezhu added a commit that referenced this issue Jan 23, 2025
@pawelru pawelru linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants