Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone handling + datetime parsing #11

Open
dillonwilliams opened this issue Aug 10, 2018 · 0 comments
Open

Add timezone handling + datetime parsing #11

dillonwilliams opened this issue Aug 10, 2018 · 0 comments

Comments

@dillonwilliams
Copy link
Contributor

dillonwilliams commented Aug 10, 2018

pacsman is currently configured with datetime_conversion = False and crashes if enabled (an integer is required (got type NoneType) on the line dataset.PatientBirthDate = None). Additionally, "Timezone Offset From UTC" is not fetched by default for any of the DicomInterface methods.

  1. Add datetime parsing utility functions in pacsman that take in DA and TM attribute, or a DT attribute, in addition to an optional offset attribute. The local timezone is added to the return datetime if no offset is present.*

  2. Try to get PynetdicomClient and FilesystemDicomClient working correctly with datetime_conversion set to True. If there's some problem, check the config and throw an exception if set to true.

*From the standard:
"A Date Time value without the optional suffix is interpreted to be in the local time zone of the application creating the Data Element, unless explicitly specified by the Timezone Offset From UTC (0008,0201)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant