Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.8 and improve type hints #31

Open
russellkan opened this issue Apr 14, 2020 · 0 comments
Open

Update to Python 3.8 and improve type hints #31

russellkan opened this issue Apr 14, 2020 · 0 comments

Comments

@russellkan
Copy link
Contributor

Python 3.8 supports TypedDict, defined in PEP 589. We should use this to improve the type hints for the dictionaries used to represent objects in the various JSON files.

Example:

class CiodModuleDict(TypedDict):
    ciodId: str
    moduleId: str
    usage: str
    conditionalStatement: Optional[str]
    informationEntity: str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant