Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DICOM Standard consistency checks #22

Open
johndgiese opened this issue Feb 26, 2020 · 0 comments
Open

DICOM Standard consistency checks #22

johndgiese opened this issue Feb 26, 2020 · 0 comments
Assignees
@russellkan
Milestone
v1.0

Comments

@johndgiese
Copy link
Contributor

johndgiese commented Feb 26, 2020 •
edited
Loading

We should begin adding tests to check that the standard is consistent with itself.

To start, we can add a check to make sure that the retired attributes in part 15 are consistent with part 5.
@johndgiese johndgiese added this to the v1.0 milestone Feb 26, 2020
russellkan added a commit that referenced this issue Mar 16, 2020
@russellkan
Check for property consistency between tables 6-1 and E.1-1
1722fc2 
- Update standard
- Issue #22
@russellkan russellkan mentioned this issue Mar 16, 2020
Merged
@russellkan russellkan self-assigned this Mar 17, 2020
russellkan added a commit that referenced this issue May 7, 2020
@russellkan
Merge duplicate nodes in macro_to_attributes
f3f3251 
- Add duplicate node/key tests to e2e test file
- Issue #22
russellkan added a commit that referenced this issue May 8, 2020
@russellkan
Merge duplicate nodes in macro_to_attributes
815793e 
- Add duplicate node/key tests to e2e test file
- Issue #21 and #22
russellkan added a commit that referenced this issue May 12, 2020
@russellkan
Add new tests
e8e62e7 
- Add unit test to check that all URLs in the 'linkToStandard' property are valid
- Add e2e tests to check that all references in module_to_attribute.json and macro_to_attribute.json exist in references.json
- Issue #21 and #22
@russellkan russellkan mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russellkan russellkan

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@johndgiese @russellkan