feat: ink kit pill component #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ink-victor
force-pushed
the
feat/ink-kit-pill-component
branch
2 times, most recently
from
d3fd142 to
7802835
Compare
ink-victor
changed the title
ink-victor
force-pushed
the
feat/ink-kit-pill-component
branch
from
7802835 to
8fb32f2
Compare
ink-victor
force-pushed
the
feat/ink-kit-pill-component
branch
from
8fb32f2 to
34265ce
Compare
fran-ink
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Tag component built using CVA (Class Variance Authority), following shadcn/ui's proven component architecture. This approach provides a flexible and type-safe way to manage component variants while maintaining a clean, maintainable codebase. By leveraging CVA's compound variants and TypeScript integration, we get robust type checking, predictable styling, and an extensible API that makes it easy to add new variants or modify existing ones. The component seamlessly integrates with our design system's tokens and follows best practices for React component development.