Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementing cache handlers #14

Closed
seliopou opened this issue Aug 5, 2015 · 2 comments
Closed

Finish implementing cache handlers #14

seliopou opened this issue Aug 5, 2015 · 2 comments
Labels

Comments

@seliopou
Copy link
Member

seliopou commented Aug 5, 2015

Time parsing and comparison have not yet been implemented, mostly due to hesitance in adding calendarlib as a dependency. It may be worthwhile considering ptime for this use case as well.

The decision nodes in question are v3h11, v3h12, and v3l13.

@seliopou seliopou added the bug label Aug 5, 2015
@tmcgilchrist
Copy link
Contributor

I've done h11 and h12 here but using calendarlib rather than ptime. What were your concerns about calendarlib? I settled for it cause it had the closest function to what I'd use in Haskell of_string : string -> string -> Time.t thought ideally it'd be an option of time rather than exceptions.

@seliopou
Copy link
Member Author

This was done a while ago, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants