fix: duration conversion between prost and core types #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ragnar <[email protected]>
Signed-off-by: Ragnar <[email protected]>
Signed-off-by: Ragnar <[email protected]>
rnbguy
reviewed
Dec 26, 2024
Comment on lines
+6
to
+10
| pub fn duration_to_proto(d: Duration) -> Option<RawDuration> { | ||
| let seconds = i64::try_from(d.as_secs()).ok()?; | ||
| let nanos = i32::try_from(d.subsec_nanos()).ok()?; | ||
| Some(RawDuration { seconds, nanos }) | ||
| } |
There was a problem hiding this comment.
Not really sure if you understood my original issue because I need to have RawDuration: From<Duration> i.e. infallible duration_to_proto.
|
I will close this PR as it doesn't resolve the linked issue. This needs to be resolved at external dependencies. For further context, check the linked issues (at remote repos) in the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of converting durations between Prost types and core Rust types. It introduces utility functions for handling these conversions safely and updates the affected modules to use these utilities.
Fixes
Fixes #1376
Description of Changes
Critical Files to Review
ibc-clients/ics07-tendermint/types/src/client_state.rsibc-primitives/src/types/duration.rsibc-primitives/src/types/mod.rsPR Author Checklist:
unclog.Durationand coreDuration#1376).Reviewer Checklist:
Files changedtab.👋 Thank you for reviewing this PR! Please feel free to provide any feedback or additional requirements for changes.