New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks ibc-rs changes up to v0.49.1 #147

Merged

Farhad-Shabani merged 12 commits into main from farhad/track-ibc-rs-0490

Jan 4, 2024

Merged

Tracks ibc-rs changes up to v0.49.1 #147

chore: update ibc to v0.49.1

This check has been archived and is scheduled for deletion. Learn more about checks retention

GitHub Actions / clippy failed Jan 4, 2024 in 0s

clippy

9 errors

Details

Results

Message level	Amount
Internal compiler error	0
Error	9
Warning	0
Note	0
Help	0

Versions

rustc 1.75.0 (82e1608df 2023-12-21)
cargo 1.75.0 (1d8b05cdd 2023-11-20)
clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check failure on line 165 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:165:34
    |
165 |             "upgrade".to_owned().try_into().unwrap()
    |                                  ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 153 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:153:34
    |
153 |             "staking".to_owned().try_into().unwrap()
    |                                  ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 141 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:141:30
    |
141 |             "gov".to_owned().try_into().unwrap()
    |                              ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 129 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:129:31
    |
129 |             "auth".to_owned().try_into().unwrap()
    |                               ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 117 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:117:30
    |
117 |             "ibc".to_owned().try_into().unwrap()
    |                              ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 105 in crates/app/src/modules/context.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/modules/context.rs:105:31
    |
105 |             "bank".to_owned().try_into().unwrap()
    |                               ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 298 in crates/app/src/abci/v0_37/impls.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/abci/v0_37/impls.rs:298:32
    |
298 |             .map(|event| event.try_into().unwrap())
    |                                ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions

Check failure on line 227 in crates/app/src/abci/v0_37/impls.rs

github-actions / clippy

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
   --> crates/app/src/abci/v0_37/impls.rs:227:40
    |
227 |                     .map(|event| event.try_into().unwrap())
    |                                        ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `#[deny(clippy::unnecessary_fallible_conversions)]` implied by `#[deny(warnings)]`

Check failure on line 7 in crates/app/src/modules/ibc/mod.rs

github-actions / clippy

unused import: `client_contexts::*`

error: unused import: `client_contexts::*`
 --> crates/app/src/modules/ibc/mod.rs:7:9
  |
7 | pub use client_contexts::*;
  |         ^^^^^^^^^^^^^^^^^^
  |
note: the lint level is defined here
 --> crates/app/src/lib.rs:3:5
  |
3 |     warnings,
  |     ^^^^^^^^
  = note: `#[deny(unused_imports)]` implied by `#[deny(warnings)]`

View more details on GitHub Actions