We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.ok()
Result
There are a few Result::ok() calls in the source code - a few of them are redundant, and a few of them are used wrongly.
Result::ok()
Option
basecoin-rs/crates/app/src/modules/ibc/router.rs
Lines 64 to 72 in dc3b43a
basecoin-rs/crates/app/src/abci/v0_38/tendermint.rs
Lines 75 to 82 in dc3b43a
Codec
JsonCodec
basecoin-rs/crates/store/src/utils/codec.rs
Lines 26 to 33 in dc3b43a
The Codec trait should have an associated type Error which lets us return a Result with the failure type.
Error
The text was updated successfully, but these errors were encountered:
TypedStore
.unwrap()
C::decode
No branches or pull requests
There are a few
Result::ok()
calls in the source code - a few of them are redundant, and a few of them are used wrongly.Option
toResult
and then toOption
. This is redundant as we can simply use the firstOption
.basecoin-rs/crates/app/src/modules/ibc/router.rs
Lines 64 to 72 in dc3b43a
basecoin-rs/crates/app/src/abci/v0_38/tendermint.rs
Lines 75 to 82 in dc3b43a
Codec
implementations. For example, withJsonCodec
,basecoin-rs/crates/store/src/utils/codec.rs
Lines 26 to 33 in dc3b43a
The
Codec
trait should have an associated typeError
which lets us return aResult
with the failure type.The text was updated successfully, but these errors were encountered: