diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1e53cdaf..bcebeb36 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,6 +50,7 @@ We use a variation on [BEM Naming Conventions](http://getbem.com/introduction/) ```css .component-name--element__modifier ``` + ```css // example: .button--checkbox__active @@ -101,16 +102,20 @@ We offer larger groups of components that are intended to be used together close import {FruitApple} from './FruitApple' import {FruitOrange} from './FruitOrange' ``` + ```tsx export class Fruit { public static Apple = FruitApple public static Orange = FruitOrange } ``` + This enables usage like so: + ```tsx import {Fruit} from '@influxdata/clockface' ``` + ```tsx @@ -133,6 +138,7 @@ import {Fruit} from '@influxdata/clockface' FruitExample.md Fruit.stories.tsx ``` + We strongly encourage including examples of all the components in a family working together ### 4. The Consistent Customization Pattern @@ -158,6 +164,6 @@ $cf-radius: 4px; When creating or modifying components use these size variables. There also other variables located in [variables.scss](https://github.com/influxdata/clockface/blob/master/src/Styles/variables.scss) that are useful for ensuring visual consistency --------------- +--- # More Coming Soon diff --git a/package.json b/package.json index d3193c6f..35ff1311 100644 --- a/package.json +++ b/package.json @@ -108,4 +108,4 @@ "storybook": "start-storybook -p 9001 -c .storybook", "publishStorybook": "storybook-to-ghpages --out=.out" } -} \ No newline at end of file +} diff --git a/src/Components/ColorPicker/ColorPickerSwatch.tsx b/src/Components/ColorPicker/ColorPickerSwatch.tsx index 66f2d576..c021326a 100644 --- a/src/Components/ColorPicker/ColorPickerSwatch.tsx +++ b/src/Components/ColorPicker/ColorPickerSwatch.tsx @@ -62,10 +62,12 @@ export const ColorPickerSwatch = forwardRef< onClick(hex) } + const title = name ? name : hex + return (
{}} + /* eslint-enable */ backgroundColor={InfluxColors.Pool} size={ComponentSize.Small} > @@ -515,7 +517,9 @@ resourceListExampleStories.add( name="CRIT" color="#da3434" size={ComponentSize.ExtraSmall} + /* eslint-disable */ onDelete={() => {}} + /* eslint-enable */ />