From 52b21a60c93b884483a6ce150b855b8340f0c8ff Mon Sep 17 00:00:00 2001
From: Felipe Cardozo <fraifelipe@gmail.com>
Date: Thu, 23 Jan 2025 16:23:42 -0300
Subject: [PATCH] fix: benchmark default bytesizes

---
 Cargo.toml                                |  2 +-
 crates/fluvio-benchmark/src/config/mod.rs | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 8a1467a9ea..45f2fa48ad 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -69,7 +69,7 @@ async-trait = { version = "0.1.41", default-features = false }
 base64 = "0.22.0"
 blocking = "1.1.0"
 bytes = "1.7.2"
-bytesize = "1.1.0"
+bytesize = "1.3.0"
 cargo_toml = "0.20.3"
 cargo-generate = { version = "0.21", default-features = false }
 cfg-if = "1.0.0"
diff --git a/crates/fluvio-benchmark/src/config/mod.rs b/crates/fluvio-benchmark/src/config/mod.rs
index 4d5be0746e..9fadc1f044 100644
--- a/crates/fluvio-benchmark/src/config/mod.rs
+++ b/crates/fluvio-benchmark/src/config/mod.rs
@@ -11,9 +11,9 @@ use bytesize::ByteSize;
 
 use crate::utils;
 
-const DEFAULT_BATCH_SIZE: ByteSize = ByteSize::kib(16);
+const DEFAULT_BATCH_SIZE: &str = "16kib";
 const DEFAULT_QUEUE_SIZE: u64 = 10;
-const DEFAULT_MAX_REQUEST_SIZE: ByteSize = ByteSize::mib(32);
+const DEFAULT_MAX_REQUEST_SIZE: &str = "32mib";
 const DEFAULT_LINGER: &str = "0ms";
 const DEFAULT_SERVER_TIMEOUT: &str = "5000ms";
 const DEFAULT_COMPRESSION: Compression = Compression::None;
@@ -23,7 +23,7 @@ const DEFAULT_WORKER_TIMEOUT: &str = "3000s";
 const DEFAULT_RECORD_KEY_ALLOCATION_STRATEGY: RecordKeyAllocationStrategy =
     RecordKeyAllocationStrategy::NoKey;
 const DEFAULT_NUM_PRODUCERS: u64 = 1;
-const DEFAULT_RECORD_SIZE: ByteSize = ByteSize::kib(5);
+const DEFAULT_RECORD_SIZE: &str = "5kib";
 const DEFAULT_NUM_RECORDS: u64 = 10_000;
 const DEFAULT_PARTITIONS: u32 = 1;
 const DEFAULT_REPLICAS: u32 = 1;
@@ -38,13 +38,13 @@ pub enum BenchmarkConfig {
 #[derive(Debug, Parser, Clone, Builder)]
 pub struct ProducerConfig {
     /// Size of each batch
-    #[arg(short, long, value_name = "bytes", default_value_t = DEFAULT_BATCH_SIZE)]
+    #[arg(short, long, value_name = "bytes", default_value = DEFAULT_BATCH_SIZE)]
     pub batch_size: ByteSize,
     /// Number of records to send
     #[arg(short, long, default_value_t = DEFAULT_QUEUE_SIZE)]
     pub queue_size: u64,
     /// Maximum size of a request
-    #[arg(long, value_name = "bytes", default_value_t = DEFAULT_MAX_REQUEST_SIZE)]
+    #[arg(long, value_name = "bytes", default_value = DEFAULT_MAX_REQUEST_SIZE)]
     pub max_request_size: ByteSize,
     /// Time to wait for new records
     #[arg(short, long, value_parser = humantime::parse_duration, default_value = DEFAULT_LINGER)]
@@ -75,7 +75,7 @@ pub struct ProducerConfig {
     #[clap(long, default_value_t = DEFAULT_NUM_RECORDS)]
     pub num_records: u64,
     /// Size of each record in bytes
-    #[arg(long, value_name = "bytes", default_value_t = DEFAULT_RECORD_SIZE)]
+    #[arg(long, value_name = "bytes", default_value = DEFAULT_RECORD_SIZE)]
     pub record_size: ByteSize,
 
     /// Number of partitions for the topic