[1.19.2] Split Nether ores into its own configured feature #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Mining Master has a single configured feature for ores, differentiated by block tag. Nether ores use the block tag
#minecraft:base_stone_netherto determine if they should be placed in the placed feature. Unfortunately since the configured feature is applied to both the Overworld and The Nether, mods that add Overworld features or terrain with base stone Nether blocks may see Mining Master's ores appear in them. This PR fixes that by isolating the Nether ores configured feature into its own file.Here you can see that Nether ores still spawn properly.
Caution
Splitting off the Nether ores into its own features is a breaking change. Data packs that add to, or override, the current configured feature will not see their new Nether ores in the game if they do not use their own features.