From a6c140cd417ce2b6810ce3d9947f6600fb2ca4d9 Mon Sep 17 00:00:00 2001 From: exoego Date: Thu, 12 Sep 2019 20:04:22 +0900 Subject: [PATCH 1/3] Update bn.js to address Buffer deprecation --- package-lock.json | 70 +++++++++++++++++++++++++++++++++++++++++++++-- package.json | 2 +- 2 files changed, 68 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index efb9c1c2..ada25ed2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -239,6 +239,14 @@ "bn.js": "^4.0.0", "inherits": "^2.0.1", "minimalistic-assert": "^1.0.0" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "assert": { @@ -430,9 +438,9 @@ "dev": true }, "bn.js": { - "version": "4.11.8", - "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", - "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==" + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-5.0.0.tgz", + "integrity": "sha512-bVwDX8AF+72fIUNuARelKAlQUNtPOfG2fRxorbVvFk4zpHbqLrPdOGfVg5vrKwVzLLePqPBiATaOZNELQzmS0A==" }, "brace-expansion": { "version": "1.1.11", @@ -702,6 +710,14 @@ "requires": { "bn.js": "^4.1.0", "randombytes": "^2.0.1" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "browserify-sign": { @@ -717,6 +733,14 @@ "elliptic": "^6.0.0", "inherits": "^2.0.1", "parse-asn1": "^5.0.0" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "browserify-zlib": { @@ -1162,6 +1186,14 @@ "requires": { "bn.js": "^4.1.0", "elliptic": "^6.0.0" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "create-hash": { @@ -1441,6 +1473,14 @@ "bn.js": "^4.1.0", "miller-rabin": "^4.0.0", "randombytes": "^2.0.0" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "dom-serializer": { @@ -1530,6 +1570,14 @@ "inherits": "^2.0.1", "minimalistic-assert": "^1.0.0", "minimalistic-crypto-utils": "^1.0.0" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "emoji-regex": { @@ -4429,6 +4477,14 @@ "requires": { "bn.js": "^4.0.0", "brorand": "^1.0.1" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "mime": { @@ -5451,6 +5507,14 @@ "parse-asn1": "^5.0.0", "randombytes": "^2.0.1", "safe-buffer": "^5.1.2" + }, + "dependencies": { + "bn.js": { + "version": "4.11.8", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-4.11.8.tgz", + "integrity": "sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA==", + "dev": true + } } }, "pump": { diff --git a/package.json b/package.json index 07774c10..6ae2472e 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "mocha": "^6.1.4" }, "dependencies": { - "bn.js": "^4.4.0", + "bn.js": "^5.0.0", "brorand": "^1.0.1", "hash.js": "^1.0.0", "hmac-drbg": "^1.0.0", From 3d7b3b284cbc8454501f5f0d6c3560db9eaa642b Mon Sep 17 00:00:00 2001 From: exoego Date: Thu, 12 Sep 2019 07:25:54 +0900 Subject: [PATCH 2/3] Use hex chars only since bn.js 5.0.0 complains about non-hex chars --- test/ecdsa-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ecdsa-test.js b/test/ecdsa-test.js index 831ac199..a12ef7dd 100644 --- a/test/ecdsa-test.js +++ b/test/ecdsa-test.js @@ -61,7 +61,7 @@ describe('ECDSA', function() { it('should have `signature.s <= keys.ec.nh`', function() { // key.sign(msg, options) - var sign = keys.sign('hello', { canonical: true }); + var sign = keys.sign('deadbeef', { canonical: true }); assert(sign.s.cmp(keys.ec.nh) <= 0); }); From 1894eb94fc1ffaac6b793f66b67e7f217823b28d Mon Sep 17 00:00:00 2001 From: exoego Date: Mon, 20 Jan 2020 17:08:19 +0900 Subject: [PATCH 3/3] Update bn.js --- package-lock.json | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index ada25ed2..cc898d2c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -438,9 +438,9 @@ "dev": true }, "bn.js": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-5.0.0.tgz", - "integrity": "sha512-bVwDX8AF+72fIUNuARelKAlQUNtPOfG2fRxorbVvFk4zpHbqLrPdOGfVg5vrKwVzLLePqPBiATaOZNELQzmS0A==" + "version": "5.1.1", + "resolved": "https://registry.npmjs.org/bn.js/-/bn.js-5.1.1.tgz", + "integrity": "sha512-IUTD/REb78Z2eodka1QZyyEk66pciRcP6Sroka0aI3tG/iwIdYLrBD62RsubR7vqdt3WyX8p4jxeatzmRSphtA==" }, "brace-expansion": { "version": "1.1.11", diff --git a/package.json b/package.json index 6ae2472e..6ffed54f 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "mocha": "^6.1.4" }, "dependencies": { - "bn.js": "^5.0.0", + "bn.js": "^5.1.1", "brorand": "^1.0.1", "hash.js": "^1.0.0", "hmac-drbg": "^1.0.0",