Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT MERGE YET] port carrying from nf and/or dv #1693

Closed
wants to merge 8 commits into from

Conversation

mqole
Copy link

@mqole mqole commented Feb 15, 2025

i THINK this works.

ports new-frontiers-14/frontier-station-14#2074, with dependencies from new-frontiers-14/frontier-station-14#834 and new-frontiers-14/frontier-station-14#501.

ripped out everything related to pseudoitems because thats something they got for goblins and vulps. testing it seems to work ok, but would really love people more experienced in c# to come look because i'm not that good at this.

also moved all the sm/throwing stuff to the new ee namespace

🆑

  • add: You can now pick your friends up like a ragdoll.
  • add: You can now throw your friends really, really far.

@FlippenPage
Copy link

got this working here but github is scary and i cant commit to this draft

@mqole
Copy link
Author

mqole commented Feb 15, 2025

could you pr it to my branch maybe?
EDIT: oh its like 3 files i can just do it manual. godspeed

@mqole mqole marked this pull request as ready for review February 15, 2025 14:23
@Lyndomen
Copy link

Might wanna peep this DeltaV-Station/Delta-v#2466

@mqole mqole changed the title port carrying from NF port carrying from DV Feb 16, 2025
@dvir001
Copy link

dvir001 commented Feb 17, 2025

Please ignore all the code for this and use new-frontiers-14/frontier-station-14#2074 as the last version for this system lol

@Lyndomen we didnt refactor this, it was fully remade on Frontier.

@Lyndomen
Copy link

Please ignore all the code for this and use new-frontiers-14/frontier-station-14#2074 as the last version for this system lol

@Lyndomen we didnt refactor this, it was fully remade on Frontier.

As I understand it there are two refactors of the carrying system, one done by frontier and one that deltanedas made last December. I'm not technically inclined enough to vouch for one or the other, but just wanted to share it if it was relevant

@mqole
Copy link
Author

mqole commented Feb 17, 2025

yep - frontier's version was done dec 5, dv's was done dec 18. tested both, theres a different feel but i'm also not technically experienced enough to vouch for either.

most recent commit at time of this comment uses frontier's contestsystem and dv's carryingsystem (& related features) totally arbitrarily.

i might open it up to the wider imp playerbase, and get some perspective as to which iteration of the carrying system is preferred. would still love any maintainers/folks with c# know-how to check out the finer minutiae of this code, but will wait to merge this pending more opinions

@mqole mqole changed the title port carrying from DV [DONT MERGE YET] port carrying from nf and/or dv Feb 17, 2025
@mqole
Copy link
Author

mqole commented Feb 20, 2025

honestly i should migrate files as a separate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants