-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONT MERGE YET] port carrying from nf and/or dv #1693
Conversation
got this working here but github is scary and i cant commit to this draft |
could you pr it to my branch maybe? |
Might wanna peep this DeltaV-Station/Delta-v#2466 |
Please ignore all the code for this and use new-frontiers-14/frontier-station-14#2074 as the last version for this system lol @Lyndomen we didnt refactor this, it was fully remade on Frontier. |
As I understand it there are two refactors of the carrying system, one done by frontier and one that deltanedas made last December. I'm not technically inclined enough to vouch for one or the other, but just wanted to share it if it was relevant |
yep - frontier's version was done dec 5, dv's was done dec 18. tested both, theres a different feel but i'm also not technically experienced enough to vouch for either. most recent commit at time of this comment uses frontier's contestsystem and dv's carryingsystem (& related features) totally arbitrarily. i might open it up to the wider imp playerbase, and get some perspective as to which iteration of the carrying system is preferred. would still love any maintainers/folks with c# know-how to check out the finer minutiae of this code, but will wait to merge this pending more opinions |
honestly i should migrate files as a separate pr. |
i THINK this works.
ports new-frontiers-14/frontier-station-14#2074, with dependencies from new-frontiers-14/frontier-station-14#834 and new-frontiers-14/frontier-station-14#501.
ripped out everything related to pseudoitems because thats something they got for goblins and vulps. testing it seems to work ok, but would really love people more experienced in c# to come look because i'm not that good at this.
also moved all the sm/throwing stuff to the new ee namespace
🆑