Salesforce and recurring donation problem with custom fields #6583

diegoinidis · 2022-10-18T07:41:22Z

diegoinidis
Oct 18, 2022

Hi, I've been referred from Priority Support to write my problem here.
I'm working to connect several donations forms with Salesforce with some custom fields. I'm using Give with add-ons Recurring Donations and Salesforce.
I'm sending custom fields data to Salesforce through give_salesforce_donation_args I'm not having any problem with one-time donations however when I want to create a recurrent donation, the method SyncRecurringDonationController::createRecurringDonationAndInitialDonation check if donation renewal exists and then delete the opportunity record created before so than the custom fields data is lost.
I could try to send this data to Salesforce through the contact or even recurring donations repositories, however I have no filters to add new information.
I can see on logs a sequence like this in any recurring donation:

Create Salesforce record: contact
"data": {
        "FirstName": "ALBERTO",
        "LastName": "DEL CARDO",
        "Email": "[email protected]"
    },
    "body": {
        "Object Class": "stdClass",
        "id": "003Fg000000f1UnIAI",
        "success": true,
        "errors": []
    },
Create Salesforce record: opportunity
"data": {
        "Type": "Donation",
        "Name": "Donation #422",
        "ContactId": "003Fg000000f1UnIAI",
        "Amount": "50.000000",
        "AccountId": "001Fg000000uDx3IAE",
        "CloseDate": "2022-10-18",
        "StageName": "Pledged",
        "DEBRA_SendDonationCertificate__c": true,
        "DEB_Codigo_postal__c": "00000",
        "DEB_Provincia__c": "pataplin",
        "DEB_Metodo_de_pago__c": "PAYPAL",
        "DEB_Tipo_de_documento__c": "DNI",
        "DEB_Numero_de_documento__c": "10000000-Z",
        "DEB_Idioma__c": "Español",
        "DEB_Origen_donacion__c": "WEB"
    },
    "body": {
        "Object Class": "stdClass",
        "id": "006Fg000000hSp3IAE",
        "success": true,
        "errors": []
    },
Create Salesforce record: npe03__Recurring_Donation__c
"data": {
        "Name": "Recurring Donation #30",
        "npe03__Contact__c": "003Fg000000f1UnIAI",
        "npe03__Amount__c": "50.0000000000",
        "npe03__Installment_Period__c": "Monthly",
        "npsp__InstallmentFrequency__c": "1",
        "npsp__RecurringType__c": "Open",
        "npe03__Open_Ended_Status__c": "Open",
        "npe03__Installments__c": "0",
        "npe03__Date_Established__c": "2022-10-18",
        "npsp__Day_of_Month__c": "18"
    },
    "body": {
        "Object Class": "stdClass",
        "id": "a09Fg0000003Lj3IAE",
        "success": true,
        "errors": []
    },

Deleted Salesforce record: opportunity/006Fg000000hSp3IAE

Updated Salesforce record: opportunity/006Fg000000hSqfIAE
"data": {
        "npe03__Recurring_Donation__c": "a09Fg0000003Lj3IAE",
        "Name": "Donation #422 (Recurring Installment)",
        "StageName": "Pledged"
    },
    "body": null,

Updated Salesforce record: opportunity/006Fg000000hSqfIAE
"data": {
        "StageName": "Closed Won"
    },
    "body": null,

How could I process these custom data without altering the addon source code?
Thanks!
Diego Mateos

Answered by jonwaldstein

Oct 24, 2022

@diegoinidis Thanks for reaching out.

(thinking out load)

If I remember correctly, some versions of Salesforce will automatically create "pledged" donations based on the parameters of the recurring donation record (end close date / installments). Looking back through our codebase - we are swapping the initial donation created with the pledged donation to prevent duplicate records. I think what you have discovered is the initial donation that holds the filter with custom fields is the one being swapped out for the auto-generated donation created by salesforce. This is obviously problematic when it comes to custom data.

Ideally, the swapping of the initial donation & the pledged donation wo…

View full answer

kjohnson · 2022-10-20T18:13:34Z

kjohnson
Oct 20, 2022
Maintainer

Hey @diegoinidis, I'm not sure if this is a bug on the SyncRecurringDonationController class or if we should add additional filters to compensate. I'll need to consult with @jonwaldstein. He is not in the office this week, but I'll follow-up with him when he returns.

0 replies

jonwaldstein · 2022-10-24T15:16:18Z

jonwaldstein
Oct 24, 2022
Maintainer

@diegoinidis Thanks for reaching out.

(thinking out load)

If I remember correctly, some versions of Salesforce will automatically create "pledged" donations based on the parameters of the recurring donation record (end close date / installments). Looking back through our codebase - we are swapping the initial donation created with the pledged donation to prevent duplicate records. I think what you have discovered is the initial donation that holds the filter with custom fields is the one being swapped out for the auto-generated donation created by salesforce. This is obviously problematic when it comes to custom data.

Ideally, the swapping of the initial donation & the pledged donation would happen in reverse order so the initial data is preserved. I would have to look back into the Salesforce api to see if that's possible. If not, then we will need to add another filter or two to compensate for the nuances of Salesforce recurring donations & auto-generated pledged donations.

As a work-around, if you were able to setup your Salesforce account without auto-generated pledged donation within your recurring donations - this would not be a problem because the initial donation would never be deleted.

0 replies

jason-best · 2023-05-24T21:34:53Z

jason-best
May 24, 2023

@jonwaldstein I am having a similar problem and turning off "auto-create" in Salesforce is causing other issues. Here is what is happening:

I am passing custom metadata to the salesforce integration. It works wonderfully for individual donations, but there are issues with recurring donations.

If "Installment Opportunity Auto-Creation" is turned OFF in SF, the recurring record is never created, but the custom metadata is passed as expected.

If "Installment Opportunity Auto-Creation" is turned ON in SF, the recurring record is created, but the custom metadata is not passed.

Is this a known issue and are you aware of any resolutions?

0 replies

jason-best · 2023-05-26T19:15:26Z

jason-best
May 26, 2023

@jonwaldstein I have added a new filter to UpdateSalesforceOpportunityAsRecurringInstallmentAction.php on line 79.
$filteredArgs = apply_filters('give_salesforce_donation_update_args', [], $donationId); $args=array_merge($args,$filteredArgs);
I am then able to add my custom metadata to the updated Opportunity. It is working well.

How could I officially contribute this to the plugin?

1 reply

jonwaldstein Jun 1, 2023
Maintainer

@jason-best thanks for the update, glad to hear the custom filter is working. Since this add-on is a private repo the best way to contribute would be to add a feedback item to our canny board https://feedback.givewp.com/ and provide your solution. This way folks can vote on it and our company can decide to move this work into our queue.

merguk · 2023-07-28T03:18:43Z

merguk
Jul 28, 2023

Hi

Salesforce partner here. We have implemented Give-WP (Salesforce and Recurring Giving plugins) for a few orgs now. We are seeing an issue which is very closely related to this post. Happy to start another fresh post, let me know.

Clients have reported this and we have replicated, in two different client environments:

Monthly donation subscribed to online.
Account/Contact/Recurring Donation (npe03__Recurring_Donation__c) all created fine
1st donation appears in SF twice: two opportunities. Both created at the same time, stage 'closed won'

One (DON1) is linked to the Recurring Donation (RD), the other (DON2) is not.
DON1 shows stage history: Pledged first, then Closed Won
DON2 shows stage history: only Closed Won

We have tried changing the NPSP 'installment opp auto creation' setting
From
Always create next installment
TO
Disable First Installment on Create

This time:

Monthly donation subscribed to online.
Account/Contact/Recurring Donation (npe03__Recurring_Donation__c) all created fine
One Opp created
DON1 not linked to RD
DON1 stage Pledged - no updates to the Stage

From previous posts, does GiveWP look for existing Opps first, deletes it if found and creates it's own Opp?

Based on the second test, something isn't quite right with the opp creation:
Stage should be Closed Won
Opp link to RD should be populated (Opportunity.npe03__Recurring_Donation__c)

Any insight into the main issue, or the second issue? Anyone else seeing this?

Cheers

5 replies

jason-best Jul 28, 2023

SF Partner here as well.
I've seen the exact same behavior.
I ended up creating a custom function in WP to push over GiveWP values to the recurring Opps. I then have a flow that cleans up the extra Opp (DON2) in your first example above.

merguk Jul 28, 2023

Awesome, thanks for confirming Jason :)

@jonwaldstein are you able to look into this?

jonwaldstein Jul 28, 2023
Maintainer

@merguk yes we can look into this, although we'll need to get this into our feedback/support queue in order to prioritize. I'll go ahead and do that and report back with a link to monitor progress.

jonwaldstein Jul 28, 2023
Maintainer

Here is the link: https://feedback.givewp.com/bug-reports/p/salesforce-and-recurring-donation-problem-with-custom-fields

merguk Aug 21, 2023

@jason-best have you ever had to deal with historical recurring donations? Do you have any insights to share?

#6871

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Salesforce and recurring donation problem with custom fields #6583

{{title}}

Replies: 5 comments 6 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Salesforce and recurring donation problem with custom fields #6583

diegoinidis Oct 18, 2022

Replies: 5 comments · 6 replies

kjohnson Oct 20, 2022 Maintainer

jonwaldstein Oct 24, 2022 Maintainer

jason-best May 24, 2023

jason-best May 26, 2023

jonwaldstein Jun 1, 2023 Maintainer

merguk Jul 28, 2023

jason-best Jul 28, 2023

merguk Jul 28, 2023

jonwaldstein Jul 28, 2023 Maintainer

jonwaldstein Jul 28, 2023 Maintainer

merguk Aug 21, 2023

diegoinidis
Oct 18, 2022

Replies: 5 comments 6 replies

kjohnson
Oct 20, 2022
Maintainer

jonwaldstein
Oct 24, 2022
Maintainer

jason-best
May 24, 2023

jason-best
May 26, 2023

jonwaldstein Jun 1, 2023
Maintainer

merguk
Jul 28, 2023

jonwaldstein Jul 28, 2023
Maintainer

jonwaldstein Jul 28, 2023
Maintainer