From 33d2ce32ceac4f02ad6d33c26b5845d8411ebb26 Mon Sep 17 00:00:00 2001 From: imashnake0 Date: Sun, 21 Jan 2024 11:03:23 -0500 Subject: [PATCH] Added more complexity rules --- .../api/anilist/AnilistMediaRepository.kt | 1 + .../imashnake/animite/features/home/Home.kt | 1 + .../animite/features/media/MediaPage.kt | 5 +++- config/detekt/detekt.yml | 24 +++++++++++++++++++ .../core/ui/TranslucentStatusBarLayout.kt | 1 + 5 files changed, 31 insertions(+), 1 deletion(-) diff --git a/api/anilist/src/main/kotlin/com/imashnake/animite/api/anilist/AnilistMediaRepository.kt b/api/anilist/src/main/kotlin/com/imashnake/animite/api/anilist/AnilistMediaRepository.kt index 7929947a..36498382 100644 --- a/api/anilist/src/main/kotlin/com/imashnake/animite/api/anilist/AnilistMediaRepository.kt +++ b/api/anilist/src/main/kotlin/com/imashnake/animite/api/anilist/AnilistMediaRepository.kt @@ -18,6 +18,7 @@ import javax.inject.Inject * @property fetchMediaList Fetches a list of [MediaListQuery.Medium]. * @property fetchMedia Fetches detailed media: [MediaQuery.Media]. */ +@Suppress("detekt:LongParameterList") class AnilistMediaRepository @Inject constructor( private val apolloClient: ApolloClient ) { diff --git a/app/src/main/java/com/imashnake/animite/features/home/Home.kt b/app/src/main/java/com/imashnake/animite/features/home/Home.kt index 7754c3ec..64441007 100644 --- a/app/src/main/java/com/imashnake/animite/features/home/Home.kt +++ b/app/src/main/java/com/imashnake/animite/features/home/Home.kt @@ -63,6 +63,7 @@ import com.imashnake.animite.core.ui.LocalPaddings @Destination @Composable +@Suppress("detekt:LongMethod") fun Home( viewModel: HomeViewModel = hiltViewModel(), navigator: DestinationsNavigator diff --git a/app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt b/app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt index 957a646e..9ab8a4fc 100644 --- a/app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt +++ b/app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt @@ -84,7 +84,10 @@ import com.ramcosta.composedestinations.annotation.Destination @Destination(navArgsDelegate = MediaPageArgs::class) @Composable -@Suppress("detekt:CognitiveComplexMethod") +@Suppress( + "detekt:CognitiveComplexMethod", + "detekt:LongMethod" +) fun MediaPage( viewModel: MediaPageViewModel = hiltViewModel() ) { diff --git a/config/detekt/detekt.yml b/config/detekt/detekt.yml index 788fd013..364b2eea 100644 --- a/config/detekt/detekt.yml +++ b/config/detekt/detekt.yml @@ -5,6 +5,30 @@ comments: complexity: CognitiveComplexMethod: active: true + ComplexCondition: + active: true + ComplexInterface: + active: true + LargeClass: + active: true + LongMethod: + active: true + LongParameterList: + active: true + MethodOverloading: + active: true + NamedArguments: + active: true + NestedBlockDepth: + active: true + NestedScopeFunctions: + active: true + ReplaceSafeCallChainWithRun: + active: true + StringLiteralDuplication: + active: true + TooManyFunctions: + active: true style: UnusedImports: diff --git a/core/src/main/kotlin/com/imashnake/animite/core/ui/TranslucentStatusBarLayout.kt b/core/src/main/kotlin/com/imashnake/animite/core/ui/TranslucentStatusBarLayout.kt index 353038e6..ebb92b3c 100644 --- a/core/src/main/kotlin/com/imashnake/animite/core/ui/TranslucentStatusBarLayout.kt +++ b/core/src/main/kotlin/com/imashnake/animite/core/ui/TranslucentStatusBarLayout.kt @@ -15,6 +15,7 @@ import androidx.compose.ui.platform.LocalDensity import androidx.compose.ui.unit.Dp @Composable +@Suppress("detekt:LongParameterList") fun TranslucentStatusBarLayout( scrollState: ScrollState, distanceUntilAnimated: Dp,