RFC: propose helper script interface for writing rules #70
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@illiliti Will this not be merged into master/main? |
I like the idea, so it is highly likely I'll merge this. Just need to sort out issues with code. |
Ella-0
force-pushed
the
master
branch
3 times, most recently
from
5ec5355 to
537ce84
Compare
|
Addressed all comments and added an example rules script to contrib with the |
One could access parent device via |
The problem with pipewire is it enumerates the following devices however the following is intended. card0 is missing. this is due to scan_devices working on |
|
Ah! Right. Forgot about this one. Well, we could switch our enumeration approach to appease pipewire. Let's keep it for later. |
Ella-0
force-pushed
the
master
branch
3 times, most recently
from
43383b5 to
4f12d0a
Compare
Ella-0
force-pushed
the
master
branch
3 times, most recently
from
41a653f to
5e8772f
Compare
| char *argv[] = { argv0, NULL }; | ||
|
|
||
| if (posix_spawn(&pid, argv0, &actions, NULL, argv, envp)) { | ||
| return -1; |
There was a problem hiding this comment.
close out_pipe and destroy actions
There was a problem hiding this comment.
int ret = posix_spawn(...);
posix_spawn_file_actions_destroy(&actions);
close(out_pipe[1]);
if (ret != 0) {
close(out_pipe[0]);
return -1;
}There was a problem hiding this comment.
You are still leaking out_pipe and actions here. Consider adopting the above code to fix the leak.
|
|
||
| int out_pipe[2]; | ||
|
|
||
| if (pipe2(out_pipe, O_CLOEXEC)) { |
Check warning
Code scanning / CodeQL
Implicit function declaration
|
@illiliti any plans to merge this or work on it? |
|
Hopefully yes |
Proposes the use of a helper script to allow setting udev properties as a replacement for udev rules. For example setting
ACP_IGNORE=1on the visense pcm in apple silicon macs.