Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching is non-existent #161

Open
rusproject opened this issue Dec 6, 2024 · 0 comments
Open

Caching is non-existent #161

rusproject opened this issue Dec 6, 2024 · 0 comments

Comments

@rusproject
Copy link

Describe the bug
Seems like this Dadata Vue component lacks any API request caching mechanism, which might be a surprise for anyone transitioning from the official dadata jQuery plugin since requests are limited and cost money.

This should at least be mentioned in the README.md.

To Reproduce
Steps to reproduce the behavior:

  1. Install the plugin or clone the repo and install, add your API key, run dev
  2. Pass debounce-wait="100" to <VueDadata> (to correspond to the jQuery plugin and make behavior more responsive)
  3. Start typing in the vue-dadata input field, repeating values over and over again
  4. See that each input triggers a new API request even if we got the result for the identical request a second ago

Expected behavior
a) Caching of requests or
b) A clear mention in the README.md that the plugin doesn't use caching

Screenshots
Screencast demonstrating the difference in sending network requests between this vue component and the official dadata plugin (which is used on the dadata.ru site and is captured in the screencast)

chrome_2024-12-06--15-36-16--657.mp4

Desktop (please complete the following information):

  • OS: Win11
  • Browser: Chrome 131
  • Version: vue-dadata 3.0.0-beta.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant