MakeCollection
helper assumes the item is a Collection
when it could be a CollectionRef
#225
Labels
bug
Something isn't working
The
MakeCollection
helper assumes the kwargs will have anitems
property. If the kwargs have no items, the helper generates aCollection
with an emptyitems
property:items=[]
.Expected behaviour:
In the case where there is no
items
property, I think aCollectionRef
should be added with noitems
prop.Observed behaviour:
The helper returns a object like this:
Potential bug location(s):
The helper always passes the kwargs to the
Collection
class:https://github.com/iiif-prezi/iiif-prezi3/blob/main/iiif_prezi3/helpers/make_collection.py#L14-L16
It seems like it should check for
items
and either set toCollection
(if present) orCollectionRef
if not.Any other comments:
The text was updated successfully, but these errors were encountered: