Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle setting bug upon switching vessel using this mod #30

Open
meltingSnowdrift opened this issue Mar 6, 2020 · 3 comments
Open

Comments

@meltingSnowdrift
Copy link

Switching vessels using this mod causes the throttle of the destination vessel of the vessel switch to be set to the throttle of the source vessel of the vessel switch.

Replication procedure:

  1. Place two vessels ("A" and "B") within physics range of each other, preferably with engines so that the effect is obvious.
  2. Make vessel A the active vessel.
  3. Move the throttle on the vessel A so that its throttle position is different from that of vessel B.
  4. Switch to vessel B using the alt-click shortcut.

Expected behaviour:

The throttle settings of vessels A and B should not change. They do not change when switching vessel the normal way using the [ ] keys.

Observed behaviour:

If the switch to vessel B is performed using the alt-click shortcut provided by this mod, the throttle setting of vessel B then becomes the same as the throttle setting you just set on vessel A. More specifically, the throttle setting of vessel B appears to become the same as the throttle input value (which is not identical to the displayed throttle value or the actual throttle position of the engines) at the moment of the switch.

@ihsoft
Copy link
Owner

ihsoft commented Mar 6, 2020

Are you sure there is nothing bound to ALT key in your game? Could you please attach a log for this case? Also, is it reproducible on a pristine game?

EVS doesn't deal with engines. Like, not at all! It only plays with the main game camera.

@meltingSnowdrift
Copy link
Author

Here is the log for a demonstration of this issue on the modded installation on which it was originally discovered. This demonstration contains both vessel switches conducted by this mod, which has the abnormal throttle behaviour, and vessel switches conducted with the [ ] keys, which do not.
KSP.log

Here is a video of the test which generated the above log:
https://youtu.be/l9WYT-yxYHQ

I next intend to test on a clean KSP 1.9.1 installation.

@meltingSnowdrift
Copy link
Author

meltingSnowdrift commented Mar 6, 2020

Here is the requested test using a clean installation. There appears to be no difference in behaviour between the clean installation and the modded one used for the previous test.

Log:
KSP.log
This log includes several instances of the testing procedure. Only the last one is depicted in the video.

Video:
https://youtu.be/clHHR-xvINc

I suspect that the procedure used to switch vessels in EVS is somehow different from the one used internally by the game when the [ ] keys are pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants