Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On handle change, expose the result of the formula. #338

Closed
siliconjungle opened this issue Sep 14, 2023 · 7 comments
Closed

On handle change, expose the result of the formula. #338

siliconjungle opened this issue Sep 14, 2023 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@siliconjungle
Copy link

Currently when a cell has a formula in it, it visually displays the result of the formula, but it doesn't expose that value in the handleChange method.

For controlled spreadsheets this is a core feature. Are there currently any workarounds for this?
@iddan
Copy link
Owner

iddan commented Sep 18, 2023

Hey, great idea. Can you elaborate a little on your use case?

@iddan iddan self-assigned this Sep 18, 2023
@iddan iddan added the enhancement New feature or request label Sep 18, 2023
@siliconjungle
Copy link
Author

Hey, great idea. Can you elaborate a little on your use case?

I'm building a code notebook where the spreadsheet is one of the block types. I'd like to be able to both query the result of a cell or the value of a cell but currently the handleChange method only exposes the value.

@iddan
Copy link
Owner

iddan commented Sep 20, 2023

Got you. I currently don't have the capacity to work on this feature but I'm open for PRs and can try to get to it when I'll have some free time.

@iddan iddan removed their assignment Sep 20, 2023
@iddan iddan added the good first issue Good for newcomers label Sep 20, 2023
@siliconjungle
Copy link
Author

I'll see if I can find some time to give it a crack. :)

BALURAM1226 added a commit to BALURAM1226/react-spreadsheet that referenced this issue Feb 11, 2024
@BALURAM1226
Issue iddan#338 : Added getEvaluatedData prop for expose the result o…
dbd59b7 
…f the formula
@BALURAM1226 BALURAM1226 mentioned this issue Feb 11, 2024
Merged
@BALURAM1226
Copy link
Contributor

BALURAM1226 commented Feb 22, 2024 •
edited
Loading

@siliconjungle, I'm actively working on resolving the CI failure issue. If it is successfully resolved and the merge is successful, you will receive the exposed data by passing onEvaluatedDataChange prop.

@BALURAM1226
Copy link
Contributor

@iddan I have pushed new commit, Please review that.

@iddan
Copy link
Owner

iddan commented Mar 6, 2024

Closed with #379

@iddan iddan closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iddan @siliconjungle @BALURAM1226