diff --git a/src/materials/ConcreteASREigenstrain.C b/src/materials/ConcreteASREigenstrain.C index 01cca11b..3b3dd10c 100644 --- a/src/materials/ConcreteASREigenstrain.C +++ b/src/materials/ConcreteASREigenstrain.C @@ -39,9 +39,12 @@ ConcreteASREigenstrain::validParams() params.addRequiredRangeCheckedParam( "characteristic_time", "characteristic_time > 0.0", - "Chracteristic ASR time (in days) at reference temprature. (tau_C(T_0))"); + "Chracteristic ASR time at reference temprature. (tau_C(T_0))"); + params.setDocUnit("characteristic_time", "d"); params.addRequiredParam("latency_time", - "Latency ASR time (in days) at reference temprature (tau_L(T_0))"); + "Latency ASR time at reference temprature (tau_L(T_0))"); + params.setDocUnit("latency_time", "d"); + // WGA - energy units? params.addRangeCheckedParam("characteristic_activation_energy", 5400.0, "characteristic_activation_energy > 0.0", @@ -275,7 +278,7 @@ ConcreteASREigenstrain::computeResidual(unsigned qp, Real scalar) // Convert current temperature to Kelvin const Real T = _temperature[qp] + _temp_offset; - // ASR characteristic and latency times (in days) + // ASR characteristic and latency times (in ) Real tau_c = _tau_c_T0 * std::exp(_Uc * (1.0 / T - 1.0 / _ref_temp)); Real tau_L = f * _tau_L_T0 * std::exp(_UL * (1.0 / T - 1.0 / _ref_temp)); @@ -309,7 +312,7 @@ ConcreteASREigenstrain::computeDerivative(unsigned qp, Real scalar) // Convert current temperature to Kelvin const Real T = _temperature[qp] + _temp_offset; - // ASR characteristic and latency times (in days) + // ASR characteristic and latency times (in ) Real tau_c = _tau_c_T0 * std::exp(_Uc * (1.0 / T - 1.0 / _ref_temp)); Real tau_L = f * _tau_L_T0 * std::exp(_UL * (1.0 / T - 1.0 / _ref_temp)); diff --git a/src/materials/ConcreteExpansionEigenstrainBase.C b/src/materials/ConcreteExpansionEigenstrainBase.C index 18de8564..afabe78e 100644 --- a/src/materials/ConcreteExpansionEigenstrainBase.C +++ b/src/materials/ConcreteExpansionEigenstrainBase.C @@ -24,6 +24,7 @@ ConcreteExpansionEigenstrainBase::validParams() "expansion_type", expansion_type, "Type of expansion resulting from volumetric strain"); params.addRangeCheckedParam( "compressive_strength", "compressive_strength > 0", "Compressive strength of concrete"); + // WGA - unclear if units are needed? params.addRangeCheckedParam( "expansion_stress_limit", "expansion_stress_limit > 0", diff --git a/src/materials/ConcreteExpansionMicrocrackingDamage.C b/src/materials/ConcreteExpansionMicrocrackingDamage.C index b9a1500f..8135d4da 100644 --- a/src/materials/ConcreteExpansionMicrocrackingDamage.C +++ b/src/materials/ConcreteExpansionMicrocrackingDamage.C @@ -42,15 +42,18 @@ ConcreteExpansionMicrocrackingDamage::validParams() "Correction factor by which the eigenstrain is multiplied before " "evaluating the damage"); + // WGA - [m/m] ??? params.addRequiredRangeCheckedParam( "microcracking_initiation_strain", "microcracking_initiation_strain > 0", - "Linear strain at which the microcracking initiates (in [m/m])"); + "Linear strain at which the microcracking initiates"); + params.setDocUnit("microcracking_initiation_strain", "[m/m]"); params.addRequiredRangeCheckedParam( "microcracking_strain_branch", "microcracking_strain_branch > 0", - "Parameter controlling the rate at which the microcracking increases (in [m/m])"); + "Parameter controlling the rate at which the microcracking increases"); + params.setDocUnit("microcracking_strain_branch", "[m/m]"); params.addParam( "expansion_stress_limit", diff --git a/src/materials/ConcreteLogarithmicCreepModel.C b/src/materials/ConcreteLogarithmicCreepModel.C index fdfa2f19..850b8787 100644 --- a/src/materials/ConcreteLogarithmicCreepModel.C +++ b/src/materials/ConcreteLogarithmicCreepModel.C @@ -38,11 +38,15 @@ ConcreteLogarithmicCreepModel::validParams() 1, "long_term_characteristic_time > 0", "Rate at which the long_term viscosity increases"); - params.addCoupledVar("temperature", "Temperature variable [in Celsius]"); + // WGA - using 0C for degrees celcius + params.addCoupledVar("temperature", "Temperature variable"); + params.setDocUnit("temperature", "0C"); params.addRangeCheckedParam("activation_temperature", "activation_temperature >= 0", - "Activation temperature for the creep [in Kelvin]"); - params.addParam("reference_temperature", 20, "Reference temperature [in Celsius]"); + "Activation temperature for the creep"); + params.setDocUnit("activation_temperature", "K"); + params.addParam("reference_temperature", 20, "Reference temperature"); + params.setDocUnit("reference_temperature", "0C"); params.addCoupledVar("humidity", "Humidity variable"); params.addRangeCheckedParam("drying_creep_viscosity", "drying_creep_viscosity > 0", diff --git a/src/materials/ConcreteThermalMoisture.C b/src/materials/ConcreteThermalMoisture.C index 1511236f..e64abd7f 100644 --- a/src/materials/ConcreteThermalMoisture.C +++ b/src/materials/ConcreteThermalMoisture.C @@ -71,25 +71,36 @@ ConcreteThermalMoisture::validParams() params.addParam( "aggregate_pore_type", aggregate_pore_type, "aggregate pore structure"); - params.addParam("cement_mass", "cement mass (kg) per m^3"); - params.addParam("aggregate_mass", "aggregate mass (kg) per m^3"); + // WGA - unclear if units for following two params is kg or kg/m^3 - assuming kg + params.addParam("cement_mass", "cement mass per m^3"); + params.setDocUnit("cement_mass", "kg"); + params.addParam("aggregate_mass", "aggregate mass per m^3"); + params.setDocUnit("aggregate_mass", "kg"); params.addParam("water_to_cement_ratio", "water to cement ratio"); params.addParam("aggregate_vol_fraction", "volumetric fraction of aggregates"); params.addParam("concrete_cure_time", "concrete curing time in days"); - params.addParam("ref_density", "refernece density of porous media Kg/m^3"); - params.addParam("ref_specific_heat", "reference specific heat of concrete J/Kg/0C"); + params.addParam("ref_density", "refernece density of porous media"); + params.setDocUnit("ref_density", "kg/m^3"); + // WGA - Joules / Kilograms / ??? - what is 0C? + params.addParam("ref_specific_heat", "reference specific heat of concrete"); + params.setDocUnit("ref_specific_heat", "J/kg/0C"); + // WGA - Watts / Meters / ??? - what is C? params.addParam("ref_thermal_conductivity", - "concrete reference thermal conductivity (W/m/C)"); + "concrete reference thermal conductivity"); + params.setDocUnit("ref_thermal_conductivity", "W/m/C"); // parameters for Bazant mositure transport model - params.addParam("D1", "empirical constants (m2/s)"); + // WGA - m2 = m^2 ?? - assuming so? + params.addParam("D1", "empirical constants"); + params.setDocUnit("D1", "m^2/s"); params.addParam("n", "empirical constants"); params.addParam("critical_relative_humidity", "empirical constants"); params.addParam("coupled_moisture_diffusivity_factor", "coupling coefficient mositure transfer due to heat"); // parameters for Mensi's moisture model - params.addParam("A", "empirical constants (m2/s)"); + params.addParam("A", "empirical constants"); + params.setDocUnit("A", "m^2/s"); params.addParam("B", "empirical constants"); params.addCoupledVar("relative_humidity", "nonlinear variable name for rel. humidity"); diff --git a/src/materials/DamagePlasticityStressUpdate.C b/src/materials/DamagePlasticityStressUpdate.C index d9006449..a2bd09f4 100644 --- a/src/materials/DamagePlasticityStressUpdate.C +++ b/src/materials/DamagePlasticityStressUpdate.C @@ -39,6 +39,7 @@ DamagePlasticityStressUpdate::validParams() "ft_ep_slope_factor_at_zero_ep", "ft_ep_slope_factor_at_zero_ep <= 1 & ft_ep_slope_factor_at_zero_ep >= 0", "slope of ft vs plastic strain curve at zero plastic strain"); + // WGA - unit needed for this? params.addRequiredParam( "tensile_damage_at_half_tensile_strength", "fraction of the elastic recovery slope in tension at 0.5*ft0 after yielding");