Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FOC test procedure needs to be updated #48

Open
MSECode opened this issue Oct 30, 2024 · 4 comments
Open

2FOC test procedure needs to be updated #48

MSECode opened this issue Oct 30, 2024 · 4 comments
Assignees
Labels
domain-software Related to Software team-five Related to Team Five

Comments

@MSECode
Copy link
Member

MSECode commented Oct 30, 2024

Since there are some of the instruction of the 2FOC test procedure that are outdated we need to update them. This won't block the test but some of the instructions can be misleading to any tester so we need to clarify them well.

cc: @valegagge @fgarini

@MSECode MSECode added domain-software Related to Software team-five Related to Team Five labels Oct 30, 2024
@MSECode MSECode self-assigned this Oct 30, 2024
@MSECode
Copy link
Member Author

MSECode commented Nov 8, 2024

I've opened a PR here: https://github.com/icub-tech-iit/electronics-legacy/pull/80

where we have updated the xml files which contains the steps of the test sequence. Basically now we have integrated the instruction of a couple of tests, so that are cleaner to be read and understood.
Moreover, we have added the flashing of bl and fw on the second phase of the sequence, in a way that when we are doing the test with a goldenboard we are sure that the fw on the 2FOC is actually the test fw.

@fgarini
Copy link
Member

fgarini commented Nov 8, 2024

@MSECode about the PR is there any overlap or duplicate file to manage in the non-legay repo? im referring to https://github.com/icub-tech-iit/electronics-boards/tree/master/2foc/sw

@MSECode
Copy link
Member Author

MSECode commented Nov 12, 2024

Actually yes, but it is just for giving more details to the tester. Basically, when I show in the test procedure how to check which version of the 2foc you are using, I've also add a link to the logic. Therefore, if needed, one can check exactly if the used version of the 2foc is mounting or not the CAN-H/CAN-L resistors. So yes, we should pay attention to changing in the folders of electronics-boards if they might happen in the future.

@MSECode
Copy link
Member Author

MSECode commented Nov 22, 2024

Updates needed are ready. In order to move the related PR to ready I'll wait for the test equipment to arrive from the supplier to test if the modifications done are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software team-five Related to Team Five
Projects
None yet
Development

No branches or pull requests

2 participants