Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year schema check is incorrect #94

Open
laggycomputer opened this issue Jan 24, 2025 · 0 comments
Open

Year schema check is incorrect #94

laggycomputer opened this issue Jan 24, 2025 · 0 comments
Labels
good first task Good for newcomers

Comments

@laggycomputer
Copy link
Member

The current year schema fails to catch any missing value, because the if check was written incorrectly (code). The right hand of the strict inequality falls back to "undefined" and only this is checked. The author likely intended all three to be checked.

We should either correct this or remove that refinement step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first task Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant