Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ap exam mappings #117

Closed
wants to merge 9 commits into from
Closed

feat: ap exam mappings #117

wants to merge 9 commits into from

Conversation

laggycomputer
Copy link
Member

@laggycomputer laggycomputer commented Feb 10, 2025 •
edited
Loading

Description

Provide mappings from UCI Catalogue names of AP Exams to official names as provided by College Board.

We add a new script to the extraction pipeline which simply dumps a hardcoded map into a new table, ap_exam.
This is a database schema change.

Related Issue

Execute #116.

Motivation and Context

See issue.

How Has This Been Tested?

There are three cases of interest:

  • Passing no parameter, listing all mappings.
  • Passing a valid AP Exam as appears in UCI Catalogue; this will retrieve the mapping for only this name.
  • Passing an invalid name; this is a 404.

Screenshots (if appropriate):

REST, no query:
Screenshot_20250210_122521

REST, valid name:
Screenshot_20250210_122535

REST, invalid name:
Screenshot_20250210_123341

GraphQL, no query:
Screenshot_20250210_122428

GraphQL, valid name:
Screenshot_20250210_122246

GraphQL, invalid name:
Screenshot_20250210_123504

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code involves a change to the database schema.
  • My code requires a change to the documentation.

@laggycomputer laggycomputer linked an issue Feb 10, 2025 that may be closed by this pull request
Need AP Exam name mappings #116
Open
ecxyzzy
ecxyzzy requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits abound as is my wont. Looks good otherwise though.

apps/data-pipeline/ap-exams-importer/src/names.ts

export default {
"AP CALCULUS AB": "AP Calculus AB",
"AP CALCULUS AB SUB": "AP Calculus BC, Calculus AB subscore",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can and should be stated more concisely as "AP Calculus BC (AB subscore)". However, open to arguments for keeping it this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The College Board page calls it the

Calculus AB subscore on the Calculus BC Exam

or the

Calculus AB subscore

so I want to be as conservative as possible about how we put the AB and BC aspects together.

apps/data-pipeline/ap-exams-importer/src/names.ts
"AP CHEMISTRY": "AP Chemistry",
"AP COMP SCI A": "AP Computer Science A",
// this hasn't been offered since 2009
"AP COMP SCI AB": "AP Computer Science AB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this hasn't been offered in 2009 and it looks similar to CSA, we should consider adding an indication to the human-readable name. Perhaps something like "AP Computer Science AB (last offered 2009)".

Copy link
Member Author

@laggycomputer laggycomputer Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then this wouldn't be the official name from College Board and we are now injecting opinion.
The truth that it no longer is offered is not our concern, only worth noting for the sake of developers who stumble into the code.

@ecxyzzy ecxyzzy marked this pull request as draft February 11, 2025 06:51
@laggycomputer
Copy link
Member Author

we're gonna give this a makeover

@laggycomputer ngmi

@Awesome-E Awesome-E mentioned this pull request Feb 19, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecxyzzy ecxyzzy Awaiting requested review from ecxyzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need AP Exam name mappings
2 participants
@laggycomputer @ecxyzzy