Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Architecture Icons #152

Open
loozhengyuan opened this issue Dec 3, 2024 · 12 comments
Open

Add AWS Architecture Icons #152

loozhengyuan opened this issue Dec 3, 2024 · 12 comments

Comments

@loozhengyuan
Copy link

It will be great if we can have the official and full set of AWS Architecture icons. The icon package looks to contain a SVGs and PNGs.

I noted that the logos icon set already contains some AWS icons but they are nowhere near complete. Having the full set allows infrastructure teams to leverage on Iconify for their Mermaid.js architecture diagrams. Thank you!

@cyberalien
Copy link
Member

It is not possible for 2 reasons:

  1. Not open source (or at least I cannot see license)
  2. Impossible to maintain. Manually downloading icons is not an option, icon set must be available with some kind of version control tool, such as git repository or a package with some package manager.

@cyberalien cyberalien closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
@loozhengyuan
Copy link
Author

@cyberalien Thank you for your response. I am willing to maintain and version the icons in a repository format, optionally including the icons for GCP and Azure for completeness.

Before I commit to the work, can I clarify if this is something you are willing to incorporate?

@cyberalien
Copy link
Member

I see possible use for 16px icons.

However there is a question of license. In zip archive I don't see any mention of license and I don't see it on website either. This is not just some person publishing stuff, this is a serious company with legal team, so license is very important and I'm surprised they didn't include one.

If AWS confirms a license and it is open source, I'll be happy to add it.

32px are actually 40px, which is outside of icon size, other sizes are even bigger, so currently I don't see possibility of adding them. I do plan to add illustrations later and this will be a good fit.

@cyberalien
Copy link
Member

Reopening issue.

So main problem is license. If it is solved, icons can be added.

@cyberalien cyberalien reopened this Dec 3, 2024
@loozhengyuan
Copy link
Author

For AWS specifically, the license conditions are set out as part of https://aws.amazon.com/trademark-guidelines.

This is generally consistent with the architecture icons published by GCP and Azure, which do not provide an explicit open-source license either. Rather, the conditions are guided around fair use of the icons for diagram, documentations, presentations, etc.

@cyberalien
Copy link
Member

That's unfortunate. There are limitations on use in sections 6 and 7, which makes it not open source.

@cyberalien cyberalien closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
@loozhengyuan
Copy link
Author

I thought I should add that some of the existing icons are not explicitly freely usable without conditions either. The icon 'collection' may be licensed but these logos do come from somewhere and the use of corporate logos will always be guided by branding guidelines.

I understand where you are coming from but I felt that it is not reasonable to expect every icon to be freely usable in order to be included. IMO, the onus of compliance lies on the user to ensure that the use of these icons do not violate the terms of use.

@cyberalien
Copy link
Member

Yes, but it is different:

  • Those are not specific to AWS.
  • Author of icon set takes responsibility for dealing with logo licenses, if they apply.

I don't know if icons in those sets are taken from AWS or if they are imitations. And I don't want to know. So if there would be a legal issue, which I doubt, I would just point to source repository.

It is a gray area.

Never had any issues or requests to remove logos.

Copying icons from AWS website is different. Such set would not be an imitation, so terms do apply and license cannot be changed.

@loozhengyuan
Copy link
Author

Ok sure, thank you for sharing your perspective.

@loozhengyuan
Copy link
Author

loozhengyuan commented Jan 23, 2025

@cyberalien Thanks to the great work of @hakanson, support for AWS icons in Iconify JSON are now available through https://github.com/awslabs/aws-icons-for-plantuml/blob/main/dist/aws-icons-mermaid.json.

Would you mind reopening the issue and adding support for this?

@cyberalien cyberalien reopened this Jan 23, 2025
@cyberalien
Copy link
Member

Nice. It does come with an open source license, so it can be added.

@cyberalien
Copy link
Member

Sorry, this icon set is actually not acceptable.

Was importing it this morning, noticed that license is "No Derivatives" variation, which is not open source because it prevents modifications to icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants