Update libpfm4 to commit 4796a2 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treece-Burgess
force-pushed
the
libpfm4-update-04-11-24
branch
from
57cd0d2 to
b8de12d
Compare
Treece-Burgess
changed the title
adanalis
reviewed
Apr 17, 2024
|
@adanalis I have added the necessary comments and added system information for where the testing was done. |
added 2 commits
April 25, 2024 16:10
Current with commit 72866cbc2666820d87ebc0af3b1a16d1d5db6965 Author: Stephane Eranian <[email protected]> Date: Thu Apr 11 08:36:50 2024 -0700 fix duplicate event code for Intel SPR TOPDOWN.BAD_SPEC_SLOTS Was using same encoding as TOPDOWN.SLOTS. Fix by adding the proper event code (0xa4) and code override flag. Reported-by: <[email protected]> Signed-off-by: Stephane Eranian <[email protected]>
Current with commit 1c0cdb91bc79eb1bc827e022f0a3738f124796a2 Author: Stephane Eranian <[email protected]> Date: Mon Apr 15 17:27:33 2024 -0700 fix uninitialized variable in perf_examples/task.c Commit 9410619f922f ("update task.c example to handle hybrid") Introduced a bug by not initializing group_fd which could generate a compiler warning and a bug. Fix this by initializing group_fd to -1. Reported-by: William Cohen <[email protected]> Signed-off-by: Stephane Eranian <[email protected]>
Treece-Burgess
force-pushed
the
libpfm4-update-04-11-24
branch
from
b3d09b9 to
c0c0095
Compare
adanalis
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Current with
commit 1c0cdb91bc79eb1bc827e022f0a3738f124796a2
Author: Stephane Eranian <[email protected]>
Date: Mon Apr 15 17:27:33 2024 -0700
Note: For commit 1c0cdb91bc79eb1bc827e022f0a3738f124796a2, compiled
perf_examplesand did not see warning that was reported through perfmon2 mailing list. As well as successfully built PAPI with default components with no warnings/errors. Please see below for system information:commit 72866cbc2666820d87ebc0af3b1a16d1d5db6965
Author: Stephane Eranian [email protected]
Date: Thu Apr 11 08:36:50 2024 -0700
Note: For commit 72866cbc2666820d87ebc0af3b1a16d1d5db6965, no testing has occurred as of now due to permissions. Will loop back around to update comment once permissions have been updated and am able to test (as of 04/26/2024, have not heard back, but have re-followed up). Please see below for system information:
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests