Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Program Submitter Dashboard crashes from unexpected clinical error data #2726

Closed
joneubank opened this issue Oct 27, 2023 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@joneubank
Copy link
Member

Describe the bug

Currently seeing some program submitter dashboards (first noticed with PACA-CA) crashing. The cause is an edge case in the returned clinical error data for donors.

The specific crash is traced to the line: https://github.com/icgc-argo/platform-ui/blob/develop/components/pages/submission-system/program-dashboard/DonorDataSummary/DonorSummaryTable.tsx#L484

This is happening because there are donor error records that have the errors property that is an empty array, so errors[0] is undefined.

This page should be updated to handle empty arrays gracefully.

The root cause of the issue has to be traced back to the argo clinical api that is generating the error data with this unexpected form.

Steps To Reproduce

Reproducible in production only, due to edge case in PACA-CA submitted clinical data. Program Submitted dashboard for PACA-CA will crash after load during rendering of the DonorSummaryTable.

Expected behaviour

Page should load without crashing with data in this edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant