Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Up React Table Upgrades #2628

Closed
Buwujiu opened this issue Apr 5, 2023 · 3 comments
Closed

Wrap Up React Table Upgrades #2628

Buwujiu opened this issue Apr 5, 2023 · 3 comments
Assignees

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Apr 5, 2023

Goal

Get a new version of UI kit out (with NO old table version)so someone can take over.
Finish code review, get the typing correct.
Will need 2 days to finish the task, projected to start on April. 10.

@Buwujiu
Copy link
Contributor Author

Buwujiu commented Apr 13, 2023

will have a major version of UI kit published today.

@samrichca
Copy link
Contributor

samrichca commented Apr 25, 2023

suggested enhancements

  • change enableX to withX. I had both initially to avoid naming conflicts with react table, but now I think we can stick to withX.
  • (optional depending on clinical entity data table development) add column pinning or expose resize API to support column pinning in clinical entity data table
  • remove feature flag in platform-UI feature branch
  • update platform-UI feature branch with changes from develop
  • remove v6 from uikit
  • add types to columns & data in ProgramDonorAndFileCountsTable platform-UI
  • clinical entity data table Update Clinical Entity Data Table #2566

@Buwujiu
Copy link
Contributor Author

Buwujiu commented May 4, 2023

All the work in UI kit is done. UI kit is left to a stable version.
Dev work is done.
Still need to have a major version of UI kit published today.

Future work:

  1. migrate the platform UI to use the new ui kit.
  2. DACO and argo docs also need to use the new ui kit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants