Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize focus state on interactive components #111

Open
hlminh2000 opened this issue Jun 14, 2019 · 0 comments
Open

Standardize focus state on interactive components #111

hlminh2000 opened this issue Jun 14, 2019 · 0 comments
Labels
accessibility co-options options for co-op students hacktoberfest help wanted Extra attention is needed

Comments

@hlminh2000
Copy link
Contributor

hlminh2000 commented Jun 14, 2019

Currently, our components visually have different focus states. We want to standardize it so anything that can be focused on on the page (accessible by tab on keyboard) is highlighted in the same manner. This will improve accessibility and also make the focus state visually consistent across browsers.

Implementation details:

  • A piece of css to implement a browser :focus state that follows the forms/input/large/focus's style as laid out in https://zpl.io/adzPEOR, that can be reused, separate from any component.
  • We need a FocusWrapper component that is implemented as a <button/> with the following characteristics:
    • All browser default styling overridden to have no visual characteristics of a button
    • Uses the above mentioned css for the :focus state
  • Any component that is clickable (other than links) should be extending / wrapped by this FocusWrapper component (needs to update previously implemented components, including Button)
  • Input components (Input, Select, Checkbox, etc...) must be updated to use the above css style for their :focus state.

Design: see bottom of: https://zpl.io/2pvln6N
Size of box depends on the element (similar to the chrome default focus state)

Screen Shot 2019-06-27 at 12 00 17 PM

@rosibaj rosibaj added hacktoberfest help wanted Extra attention is needed labels Oct 1, 2019
@rosibaj rosibaj added the co-options options for co-op students label Dec 11, 2019
@rosibaj rosibaj added critical This MUST be completed for release and removed critical This MUST be completed for release labels Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility co-options options for co-op students hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants