Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary feedback #2 #150

Closed
3 of 5 tasks
kcullion opened this issue May 26, 2020 · 7 comments
Closed
3 of 5 tasks

Dictionary feedback #2 #150

kcullion opened this issue May 26, 2020 · 7 comments
Assignees

Comments

@kcullion
Copy link

kcullion commented May 26, 2020

  • Should the "type" for presenting_symptoms and treatment_type be "ARRAY" instead of "TEXT"?

  • sample registration file description, change ARGO Platform to ARGO Data Platform

  • treatment file description: A donor can have multiple treatments.
    Then in followup we say: To submit multiple follow-ups for a single donor, please submit multiple rows in the follow-up file for this donor.
    Should we describe how to add multiple treatments?

  • Should we link to the new "Dictionary overview" page, or "Clinical data validation rules" page from the dictionary?

  • treatment_type note has this sentence twice: Depending on the treatment_type selected, additional treament details may be required to be submitted.

  • delete the first one, as the second one has the "treatment" typo fixed.

@rosibaj
Copy link
Contributor

rosibaj commented May 26, 2020

Should the "type" for presenting_symptoms and treatment_type be "ARRAY" instead of "TEXT"?
@kcullion its an ARRAY of TEXT elements ( you can also have an array of intergers), so no on this.

@rosibaj
Copy link
Contributor

rosibaj commented May 26, 2020

Should we link to the new "Dictionary overview" page, or "Clinical data validation rules" page from the dictionary? @kcullion can you move this as a ticket to the docs site? i think yes - can you define where to add that link for ui review?

@kcullion
Copy link
Author

@rosibaj yep, made a ticket for me to do a quick proposal icgc-argo/argo-docs#241

@rosibaj
Copy link
Contributor

rosibaj commented Jun 4, 2020

third point in #158

@rosibaj
Copy link
Contributor

rosibaj commented Jun 4, 2020

6ths point is already resolved

@rosibaj
Copy link
Contributor

rosibaj commented Jun 4, 2020

4th point address in pr #158

@rosibaj
Copy link
Contributor

rosibaj commented Jun 4, 2020

Tested on staging with dictionary 0.14, migrated to prod on dictionary 0.14

@rosibaj rosibaj closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants